bugFreeciv - Bugs: bug #20221, Script signal...

 
 
Show feedback again

bug #20221: Script signal "unit_lost" not always emitted when unit lost

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri 05 Oct 2012 04:05:14 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.3, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 Nov 2012 11:34:03 PM UTC, SVN revision 22012:

Always emit "unit_lost" scripting signal when unit lost.

Originally reported by Jacob Nevins

See gna bug #20221

(Browse SVN revision 22012)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 19 Nov 2012 11:33:59 PM UTC, SVN revision 22011:

Always emit "unit_lost" scripting signal when unit lost.

Originally reported by Jacob Nevins

See gna bug #20221

(Browse SVN revision 22011)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 19 Nov 2012 11:33:53 PM UTC, SVN revision 22010:

Always emit "unit_lost" scripting signal when unit lost.

Originally reported by Jacob Nevins

See gna bug #20221

(Browse SVN revision 22010)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 17 Nov 2012 01:08:34 AM UTC, comment #1:

Patches

(file #16767, file #16768)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 05 Oct 2012 04:05:14 AM UTC, original submission:

bug #19821 mentions (3) that "unit_lost" signal is not emitted in case of unit being lost with its transport.
That's not the only place where server_remove_unit() is called without emitting the signal. All callers should be checked (signal emitting potentially moved in to server_remove_unit()).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Jan 2013 11:12:59 AM UTCjtnDependencies-=>bugs #19821 is dependent
    Mon 19 Nov 2012 11:34:30 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 17 Nov 2012 01:08:34 AM UTCcazfiAttached File-=>Added UnitLostSignalAlways-S2_3.patch, #16768
      StatusNone=>Ready For Test
    Sat 17 Nov 2012 01:08:33 AM UTCcazfiAttached File-=>Added UnitLostSignalAlways.patch, #16767
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup