bugFreeciv - Bugs: bug #20304, Some requirement types always...

 
 
Show feedback again

bug #20304: Some requirement types always required even with RPT_POSSIBLE

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 18 Nov 2012 11:04:14 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.3, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 04 Dec 2012 10:05:05 PM UTC, comment #7:

Thanks.

FWIW, I tried S2_3 autogames with the same seeds with r22032 (before this change) and r22052 (after it). The outcome was very different. (But there were no problems.)

Jacob Nevins <jtn>
Project Administrator
Tue 27 Nov 2012 12:35:38 AM UTC, comment #6:

> Any idea of specific behaviour changes this will cause


For the supplied rulesets I'm not aware of any change, but my ruleset checking has not been vigorous.

Actually, it's the client thats more affected. Server & ai know exact situation in most cases, but client lacks information so it have to guess with RPT_POSSIBLE or RPT_CERTAIN:
- Buildings are not marked redundant when it's possible that they are usefull (thus the change is: "with some rulesets less buildings are marked redundant")
- Buildings can be added to worklist if it's possible that they are buildable in the future

- When city cannot build next item from worklist and reasons are listed in chat, after this patch false positives are never sent (but we lose also some correct ones - which we already did with partially working RPT_POSSIBLE)

- AI thinks that researching a tech would allow it to build specific buildings when ever it's possible that other requirement are fulfilled.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 27 Nov 2012 12:11:15 AM UTC, comment #5:

This change could have quite wide-ranging effects, I think -- particularly on the AI's thinking?
Any idea of specific behaviour changes this will cause, or am I going to have to put something like "the Freeciv engine generally believes more things are possible" in the release notes?

Jacob Nevins <jtn>
Project Administrator
Sat 24 Nov 2012 04:51:51 AM UTC, SVN revision 22036:

Fixed several requirement types to be considered fullfilled
when they cannot be checked and RPT_POSSIBLE is requested.

See gna bug #20304

(Browse SVN revision 22036)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 24 Nov 2012 04:51:47 AM UTC, SVN revision 22035:

Fixed several requirement types to be considered fullfilled
when they cannot be checked and RPT_POSSIBLE is requested.

See gna bug #20304

(Browse SVN revision 22035)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 24 Nov 2012 04:51:41 AM UTC, SVN revision 22034:

Fixed several requirement types to be considered fullfilled
when they cannot be checked and RPT_POSSIBLE is requested.

See gna bug #20304

(Browse SVN revision 22034)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 19 Nov 2012 04:00:47 AM UTC, comment #1:

Patches

(file #16782, file #16783, file #16784)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 18 Nov 2012 11:04:14 AM UTC, original submission:

Noticed with TerrainClass requirement, but from the source code it seems also many other requirement types lack related handling.

When are_reqs_active is passed NULL tile (tile is not known) and RPT_POSSIBLE (asking if it's possible that requirements are active), TerrainClass requirements are considered not active.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16782:  RPTPossible.patch added by cazfi (8kB - text/x-diff)
file #16783:  RPTPossible-S2_4.patch added by cazfi (7kB - text/x-diff)
file #16784:  RPTPossible-S2_3.patch added by cazfi (7kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 24 Nov 2012 04:52:12 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 19 Nov 2012 04:00:47 AM UTCcazfiAttached File-=>Added RPTPossible.patch, #16782
      Attached File-=>Added RPTPossible-S2_4.patch, #16783
      Attached File-=>Added RPTPossible-S2_3.patch, #16784
      StatusNone=>Ready For Test
      Planned Release=>2.3.3, 2.4.0, 2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup