Freeciv - Bugs: bug #20348, Fortresses not claimed when... [Gna!]

Freeciv - Bugs: bug #20348, Fortresses not claimed when...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Patches
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search

Show feedback again

bug #20348: Fortresses not claimed when entering war

Submitted by:	Marko Lindqvist <cazfi>
Submitted on:	Mon 03 Dec 2012 08:29:42 AM UTC

Category:	general	Severity:	3 - Normal
Priority:	5 - Normal	Status:	Fixed
Assigned to:	Marko Lindqvist <cazfi>	Open/Closed:	Closed
Release:		Operating System:	None
Planned Release:	2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich Markup):

You are not logged in

Please log in, so followups can be emailed to you.

( Jump to the original submission)

Tue 11 Dec 2012 09:43:26 AM UTC, SVN revision 22070: Units already on tile with claimable base claim the base when ceasefire between unit owner and base owner runs out. See gna bug #20348 (Browse SVN revision 22070)	Marko Lindqvist <cazfi>
Tue 11 Dec 2012 09:43:22 AM UTC, SVN revision 22069: Units already on tile with claimable base claim the base when ceasefire between unit owner and base owner runs out. See gna bug #20348 (Browse SVN revision 22069)	Marko Lindqvist <cazfi>
Tue 11 Dec 2012 09:43:17 AM UTC, SVN revision 22068: Units already on tile with claimable base claim the base when ceasefire between unit owner and base owner runs out. See gna bug #20348 (Browse SVN revision 22068)	Marko Lindqvist <cazfi>
Fri 07 Dec 2012 08:42:27 PM UTC, comment #5: Untested patches to resolve the issue with ceasefire running out too. (file #16832, file #16833)	Marko Lindqvist <cazfi>
Fri 07 Dec 2012 10:55:48 AM UTC, SVN revision 22058: Units already on tile with claimable base claim the base when unit owner and base owner enter war due to cancelled peace pact. See gna bug #20348 (Browse SVN revision 22058)	Marko Lindqvist <cazfi>
Fri 07 Dec 2012 10:55:43 AM UTC, SVN revision 22057: Units already on tile with claimable base claim the base when unit owner and base owner enter war due to cancelled peace pact. See gna bug #20348 (Browse SVN revision 22057)	Marko Lindqvist <cazfi>
Fri 07 Dec 2012 10:55:39 AM UTC, SVN revision 22056: Units already on tile with claimable base claim the base when unit owner and base owner enter war due to cancelled peace pact. See gna bug #20348 (Browse SVN revision 22056)	Marko Lindqvist <cazfi>
Mon 03 Dec 2012 09:18:26 AM UTC, comment #1: Previous patches took care just the case that war is entered due to pact cancellation. They still do not fix the case of ceasefire running out. Existing patch is still better than nothing. If there's no objections I'll commit it for 2.3.3 already, while more extensive fix will become available only later.	Marko Lindqvist <cazfi>
Mon 03 Dec 2012 08:29:42 AM UTC, original submission: I managed to setup situation considered illegal in some parts of the code (at least savegame loading "fixes" this to "sane") of having unit in fortress that is enemy of the fortress owner. Simply move the unit to fortress while players are at peace, and declare war only after that. When war is declared, existing units in fortress tiles are not checked.	Marko Lindqvist <cazfi>

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Comment:

Attached Files

file #16832: CeasefireEndFortressClaim.patch added by cazfi (3kB - text/x-diff)

file #16833: CeasefireEndFortressClaim-S2_4.patch added by cazfi (3kB - text/x-diff)

file #16822: WarClaimBase.patch added by cazfi (2kB - text/x-diff)

file #16823: WarClaimBase-S2_4.patch added by cazfi (2kB - text/x-diff)

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by cazfi (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 10 latest changes.

Date	Changed By	Updated Field	Previous Value	Replaced By
Tue 11 Dec 2012 09:43:39 AM UTC	cazfi	Status	Ready For Test	Fixed
		Assigned to	None	cazfi
		Open/Closed	Open	Closed
Fri 07 Dec 2012 08:42:27 PM UTC	cazfi	Attached File	-	Added CeasefireEndFortressClaim.patch, #16832
		Attached File	-	Added CeasefireEndFortressClaim-S2_4.patch, #16833
		Planned Release	2.3.3, 2.4.0, 2.5.0	2.3.4, 2.4.0, 2.5.0
Mon 03 Dec 2012 08:59:52 AM UTC	cazfi	Attached File	-	Added WarClaimBase.patch, #16822
		Attached File	-	Added WarClaimBase-S2_4.patch, #16823
		Status	In Progress	Ready For Test
		Planned Release		2.3.3, 2.4.0, 2.5.0

Show feedback again