bugMyPaint - Bugs: bug #20371, Redraw areas: redrawing entire...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #20371: Redraw areas: redrawing entire document when painting; redraws happen with no pressure

Submitted by:  Andrew Chadwick <achadwick>
Submitted on:  Sat 15 Dec 2012 08:24:53 PM UTC  
 
Severity: 5 - BlockerPriority: 5 - Normal
Status: FixedPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: git 95225b99Planned Release: None
Operating System: Debian testing/Wheezy + Xfce4

Fri 04 Jan 2013 09:02:15 PM UTC, comment #4:

Yes, that was the correct fix. I've also removed the extraneous expandToIncludePoint function.
Fixes were included in the 1.1 release, so closing right away.

Jon Nordby <jonnor>
Project Administrator
Mon 17 Dec 2012 07:57:12 PM UTC, comment #3:

Noticed that dirty_bbox wasn't getting its area zeroed in end_atomic().

Should be fixed in https://gitorious.org/mypaint/mypaint/commit/1d4cb5416ca47410f695a9f454d5014e1479da05. I hope that's the right approach.

Andrew Chadwick <achadwick>
Project Administrator
Sun 16 Dec 2012 09:25:29 AM UTC, comment #2:

Side note to that commit: Do we really need two different C implementations of expandToIncludePoint()? There is one in mypaint-tiled-surface.c and another one in lib/helpers2.hpp now. Not counting the python implementation in lib/helpers.py.

Couldn't one of the two call the other, if it's still used at all?

Martin Renold <martinxyz>
Project Administrator
Sun 16 Dec 2012 09:12:29 AM UTC, comment #1:

Confirmed, it almost always re-renders the whole screen now.

Martin Renold <martinxyz>
Project Administrator
Sat 15 Dec 2012 08:24:53 PM UTC, original submission:

Since https://gitorious.org/mypaint/mypaint/commit/95225b99e0937828ae87c0df22fbafd6962e7615 , MyPaint is performing excessively large redraws of the entire document when painting, not just the extent of the last few dabs. The effect is visible when "Visualize Rendering" is turned on: see the attached files.

Related bug: these redraws are now happening in response to pointer motion events with a pressure of zero (mouse, hovering with a Wacom tablet). The effect is visible as a fickering of the document bbox area when "Visualize Rendering" is turned on.

Both problems were introduced at the same time:

Andrew Chadwick <achadwick>
Project Administrator

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jonnor (Posted a comment)
  • -unavailable- added by martinxyz (Posted a comment)
  • -unavailable- added by achadwick (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 04 Jan 2013 09:02:15 PM UTCjonnorStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 17 Dec 2012 07:57:12 PM UTCachadwickStatusConfirmed=>Ready For Test
    Sun 16 Dec 2012 09:12:29 AM UTCmartinxyzSeverity3 - Normal=>5 - Blocker
      StatusNone=>Confirmed
    Sat 15 Dec 2012 08:24:54 PM UTCachadwickAttached File-=>Added redraws-excessive.png, #16843
      Attached File-=>Added redraws-expected.png, #16844
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup