bugBattle for Wesnoth - Bugs: bug #20409, Seg fault going from the editor to...

 
 
Show feedback again

bug #20409: Seg fault going from the editor to multiplayer

Submitted by:  J Tyne <jamit>
Submitted on:  Sun 06 Jan 2013 01:23:06 AM UTC  
 
Category: BugSeverity: 5 - Blocker
Priority: 5 - NormalItem Group: Editor
Status: FixedPrivacy: Public
Assigned to: Fabian Müller <fendrin>Open/Closed: Closed
Release: 1.11.1 + svn (r56023)Operating System: Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 11 Jan 2013 10:24:41 PM UTC, SVN revision 56035:

Nulling resources pointers in the editor_controller's destructor.
At least fixing some of the segfaults mentioned in bug #20409.

(Browse SVN revision 56035)

Fabian Müller <fendrin>
Project MemberIn charge of this item.
Sun 06 Jan 2013 01:23:06 AM UTC, original submission:

Steps:

1) Start BfW.
2) Hit the "Map Editor" button.
3) Quit the editor (ctrl-q).
4) Hit the "Multiplayer" button.
5) Choose "Local Game" and hit "OK".
6) Select a map and hit "OK".

Segmentation fault with the map selection window still up.

The problem is that during multiplayer setup, resources::teams still points to data from the map editor, which has long since been disposed of. (I confirmed by checking the value of the pointer in the editor, then again where the crash occurs.) I did a search of the src/editor/ directory, and it looks like some pointers from resources:: are set when the editor starts, but none of them are reset to NULL when the editor closes.

J Tyne <jamit>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by fendrin (Updated the item)
  • -unavailable- added by jamit (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:27:21 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 12 Jan 2013 05:35:48 PM UTCjamitStatusReady For Test=>Fixed
    Fri 11 Jan 2013 10:25:22 PM UTCfendrinStatusConfirmed=>Ready For Test
    Fri 11 Jan 2013 10:17:26 PM UTCfendrinStatusNone=>Confirmed
    Sun 06 Jan 2013 01:27:50 AM UTCjamitItem Group None of the others=>Editor
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup