bugFreeciv - Bugs: bug #20442, Recursive transports not wiped...

 
 
Show feedback again

bug #20442: Recursive transports not wiped properly

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 19 Jan 2013 07:00:23 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 20 Jan 2013 10:56:56 PM UTC, SVN revision 22170:

Call wipe_unit() recursively for units that are drowning due to
loss of transport.

Reported by Jacob Nevins

See gna bug #20442

(Browse SVN revision 22170)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 20 Jan 2013 10:56:51 PM UTC, SVN revision 22169:

Call wipe_unit() recursively for units that are drowning due to
loss of transport.

Reported by Jacob Nevins

See gna bug #20442

(Browse SVN revision 22169)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 19 Jan 2013 07:00:23 AM UTC, original submission:

Issue 2 from bug #19821.

wip_unit() gets called recursively for units that are drowning due to loss of transport. That makes them to recursively properly wipe their own cargo too.

Nobility saving is not perfect, but I think it's good enough for us for now. It would require quite complete rewrite of the unit wiping functionality it to always find solution that causes least number of nobles to drown (it would be better to save one recursive transport that can carry two nobles than directly one noble, wiping of recursive transport may cause noble from that transport to drown when upper level proletariat already got saved)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16970:  RecursiveDrowning.patch added by cazfi (7kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 20 Jan 2013 10:57:32 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 19 Jan 2013 11:13:25 AM UTCjtnDependencies-=>bugs #19821 is dependent
    Sat 19 Jan 2013 07:00:23 AM UTCcazfiAttached File-=>Added RecursiveDrowning.patch, #16970
      Attached File-=>Added RecursiveDrowning-S2_4.patch, #16971
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup