bugFreeciv - Bugs: bug #20444, implicit declaration of function...

 
 
Show feedback again

bug #20444: implicit declaration of function 'stricoll'

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 19 Jan 2013 09:50:30 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: Microsoft Windows
Planned Release: 2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Feb 2013 10:31:15 AM UTC, SVN revision 22263:

Prefer _stricoll() over stricoll() as former is properly declared
in MinGW headers.

See gna bug #20444

(Browse SVN revision 22263)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 02 Feb 2013 10:31:11 AM UTC, SVN revision 22262:

Prefer _stricoll() over stricoll() as former is properly declared
in MinGW headers.

See gna bug #20444

(Browse SVN revision 22262)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 02 Feb 2013 10:31:04 AM UTC, SVN revision 22261:

Prefer _stricoll() over stricoll() as former is properly declared
in MinGW headers.

See gna bug #20444

(Browse SVN revision 22261)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 31 Jan 2013 11:01:59 AM UTC, comment #1:

Attached patch makes us to prefer _stricoll() instead. That one is declared.

(file #17069)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 19 Jan 2013 09:50:30 AM UTC, original submission:

There's just one warning left when compiling for Windows (crosser style build):

utility/support.c: In function 'fc_stricoll':
utility/support.c:298:3: warning: implicit declaration of function 'stricoll' [-Wimplicit-function-declaration]
utility/support.c:298:3: warning: nested extern declaration of 'stricoll' [-Wnested-externs]

I tried to figure this one out (and fix) a while back when I managed to get rid of the other warnings, but found no easy + proper fix (don't remember the details).

As the last warning this has somewhat higher priority than it otherwise would - it's the thing holding us back from enabling -Werror for Windows builds and thus detecting new problems immediately when they occur.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17069:  _StricollPrefer.patch added by cazfi (930B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 02 Feb 2013 10:31:48 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 31 Jan 2013 11:01:59 AM UTCcazfiAttached File-=>Added _StricollPrefer.patch, #17069
      StatusNone=>Ready For Test
      Planned Release=>2.3.4, 2.4.0, 2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup