bugFreeciv - Bugs: bug #20452, Unit can convert in bad...

 
 
Show feedback again

bug #20452: Unit can convert in bad circumstances

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 23 Jan 2013 11:39:46 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 28 Jan 2013 12:34:29 PM UTC, SVN revision 22227:

Added stricter legality checks for cases where unit transforms from
one type to another: upgrades or converts.
- Added native tile check for conversion
- Added cargo check for conversion
- Improved cargo check applied to both upgrade and conversion case
to check also that cargo is of suitable type

See gna bug #20452

(Browse SVN revision 22227)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Jan 2013 12:34:25 PM UTC, SVN revision 22226:

Added stricter legality checks for cases where unit transforms from
one type to another: upgrades or converts.
- Added native tile check for conversion
- Added cargo check for conversion
- Improved cargo check applied to both upgrade and conversion case
to check also that cargo is of suitable type

See gna bug #20452

(Browse SVN revision 22226)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Jan 2013 12:34:20 PM UTC, SVN revision 22225:

Added stricter legality checks for cases where unit transforms from
one type to another: upgrades or converts.
- Added native tile check for conversion
- Added cargo check for conversion
- Improved cargo check applied to both upgrade and conversion case
to check also that cargo is of suitable type

See gna bug #20452

(Browse SVN revision 22225)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 25 Jan 2013 12:04:29 AM UTC, comment #1:

- Check that conversion or upgrade target unit type can transport type of cargo unit currently holds.

(file #17014, file #17015)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 23 Jan 2013 11:39:46 PM UTC, original submission:

Unit can be converted to another type even when
1) target unit cannot exist in the tile
2) target unit has not enough space for the cargo

Fix for these attached.

This makes cargo space check equivalent to what's being done in case of unit upgrade. But this is still buggy for both upgrade and convert case; there's no check for cargo type. If there's space for 2 infantry units, that pass as transport capacity for 2 aircraft.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17014:  UnitTransformChecks.patch added by cazfi (2kB - text/x-diff)
file #17007:  ConvertTerrainCheck.patch added by cazfi (776B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Jan 2013 12:35:02 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 25 Jan 2013 12:04:29 AM UTCcazfiAttached File-=>Added UnitTransformChecks.patch, #17014
      Attached File-=>Added UnitTransformChecks-S2_3.patch, #17015
    Wed 23 Jan 2013 11:39:46 PM UTCcazfiAttached File-=>Added ConvertTerrainCheck.patch, #17007
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup