bugFreeciv - Bugs: bug #20460, One cannot upgrade unit (s)he is...

 
 
Show feedback again

bug #20460: One cannot upgrade unit (s)he is not able to build him/herself

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 28 Jan 2013 12:29:33 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 01 Feb 2013 02:58:11 PM UTC, SVN revision 22254:

Allow upgrading units even if you couldn't build the original unit.

See gna bug #20460

(Browse SVN revision 22254)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 01 Feb 2013 02:58:06 PM UTC, SVN revision 22253:

Allow upgrading units even if you couldn't build the original unit.

See gna bug #20460

(Browse SVN revision 22253)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 01 Feb 2013 02:58:01 PM UTC, SVN revision 22252:

Allow upgrading units even if you couldn't build the original unit.

See gna bug #20460

(Browse SVN revision 22252)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 29 Jan 2013 11:47:49 PM UTC, comment #2:

Attached patch removes the check if player can build current unittype. I've found no reason to do such a check.

(file #17049)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Jan 2013 01:25:44 PM UTC, comment #1:

Attached savegame is an example how this affects even default rules

1) Bribe Phalanx. You now have Phalanx without knowing Bronze Working
2) Capture Rio de Janeiro. You steal Gunpowder without knowing Bronze Working
3) Notice how you can build Musketeers in Rio de Janeiro, but cannot upgrade th phalanx you have.

(file #17035)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Jan 2013 12:29:33 PM UTC, original submission:

can_upgrade_unittype() begins with test that player can build current unittype. Can anyhbody explain why it's there?
It means that if scenario (or even bribing in special ruleset) provides player with special unit not available for him/her to build (I wonder if this prevents upgrdes of UTYF_UNIQUE units altogether, as you would be unable to build another when you already have the one you want to upgrade) there's no way to later upgrade such units to somethithing player can build.

The case where this came up was when I tried to test upgrading with giving tech for more advanced unit to player. Upgrade was not possible since I had no tech for the original unit (can't upgrade Pahalanx to Musketeers when you have Gunpowder but not Bronze Working)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17049:  UpgradeUnbuildable.patch added by cazfi (846B - text/x-diff)
file #17035:  NoUpradeRepro.sav.bz2 added by cazfi (11kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 01 Feb 2013 02:58:34 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 29 Jan 2013 11:47:49 PM UTCcazfiAttached File-=>Added UpgradeUnbuildable.patch, #17049
      StatusNone=>Ready For Test
      Planned Release=>2.3.4, 2.4.0, 2.5.0
    Mon 28 Jan 2013 01:25:44 PM UTCcazfiAttached File-=>Added NoUpradeRepro.sav.bz2, #17035
      CategoryNone=>general
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup