bugFreeciv - Bugs: bug #20472, [River|Road] move_mode...

 
 
Show feedback again

bug #20472: [River|Road] move_mode "Relaxed" assumes river/road on adjacent tile

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri 01 Feb 2013 04:12:04 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 16 Feb 2013 01:12:18 AM UTC, SVN revision 22345:

When moving diagonally move_mode "Relaxed" road, give any movement bonus
from the road only if there's road also in the tile cardinally adjacent
to both tile unit leaves and tile unit arrives to.

See gna bug #20472

(Browse SVN revision 22345)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 10 Feb 2013 01:40:51 AM UTC, comment #2:

Untested patch for this ticket.

(file #17168)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 05 Feb 2013 11:35:38 AM UTC, comment #1:

See also bug #16383 about how some units should not be able to cross such points at all.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 01 Feb 2013 04:12:04 PM UTC, original submission:

Noticed while porting river_move_mode as road.move_mode in patch #3637:

Relaxed mode let's one to easily move diagonally from river tile to river tile, but with double move cost as if two cardinal moves were made. This checks river from original and target tiles only. It's possible that there's no connection between the two but they are two separate rivers, either their starting points or turning away from each other. If the tile through which unit is considered to move has no river, applying cost based on river cost does not make sense.

patch #3637 makes road move_mode implementation identical to river_move_mode, so similar bug makes it to road.move_mode too.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 16 Feb 2013 01:12:34 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 10 Feb 2013 01:40:51 AM UTCcazfiAttached File-=>Added RelaxedMoveWithBetweenCheck.patch, #17168
      StatusNone=>Ready For Test
    Tue 05 Feb 2013 11:44:58 AM UTCcazfiPlanned Release=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup