bugFreeciv - Bugs: bug #20475, User terrain flag names not known...

 
 
Show feedback again

bug #20475: User terrain flag names not known client side

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 02 Feb 2013 03:34:44 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 05 Feb 2013 04:20:09 PM UTC, SVN revision 22285:

Unified user terrain flags code with user unit type flags.

- user_flag structure common to both types of user flags introduced
along with initialization and deinitialization functions
- User terrain flags are defined in ruleset in similar structure as
user unit type flags. This includes the fact that there's now
helptext associated with flags.
- User terrain flags are sent to client side
- Terrain help displays user flag helptext when terrain has the flag

See gna bug #20475

(Browse SVN revision 22285)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 02 Feb 2013 04:44:16 AM UTC, comment #1:

Attached patch makes user terrain flags similar to user unit type flags.

- user_flag structure common to both types of user flags introduced along with initialization and deinitialization functions
- User terrain flags are defined in ruleset in similar structure as user unit type flags. This includes the fact that there's now helptext associated with flags
- User terrain flags are sent to client side
- Terrain help displays user flag helptext when terrain has the flag

(file #17104)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 02 Feb 2013 03:34:44 AM UTC, original submission:

Alien ruleset help for "Tunnel" says:
Requires "TER_USER_1" terrain flag on the tile.

User (ruleset author) defined terrain flags are not sent to client side.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17104:  UserFlags.patch added by cazfi (17kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 Feb 2013 04:20:21 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sat 02 Feb 2013 04:44:16 AM UTCcazfiAttached File-=>Added UserFlags.patch, #17104
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup