bugFreeciv - Bugs: bug #20484, get_virtual_defense_power()...

Show feedback again

bug #20484: get_virtual_defense_power() assuming "TerrainDefense"

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 06 Feb 2013 03:29:36 AM UTC  
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.5, 2.4.0, 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Tue 19 Feb 2013 12:53:32 AM UTC, comment #2:

(Committed as r22363, r22364, r22365.)

Jacob Nevins <jtn>
Project Administrator
Thu 07 Feb 2013 05:39:45 AM UTC, comment #1:

- Fix a bug that units without "TerrainDefense" didn't get even the constant part (10) of the factor
- Replaced magic 10 with POWER_FACTOR

(file #17153, file #17154)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 06 Feb 2013 03:29:36 AM UTC, original submission:

get_virtual_defense_power() always applies terrain defense bonuses, but they should apply to only those unit classes that have "TerrainDefense" flag (land units in classic rulesets).

Fix attached.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #17153:  VirtTerrainDefense-2.patch added by cazfi (826B - text/x-diff)
file #17140:  VirtTerrainDefense.patch added by cazfi (883B - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 17 Feb 2013 04:34:14 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
    Sat 09 Feb 2013 09:49:47 PM UTCcazfiPlanned Release2.3.4, 2.4.0, 2.5.0=>2.3.5, 2.4.0, 2.5.0
    Thu 07 Feb 2013 05:39:45 AM UTCcazfiAttached File-=>Added VirtTerrainDefense-2.patch, #17153
      Attached File-=>Added VirtTerrainDefense-S2_3-2.patch, #17154
    Wed 06 Feb 2013 03:29:36 AM UTCcazfiAttached File-=>Added VirtTerrainDefense.patch, #17140
      Attached File-=>Added VirtTerrainDefense-S2_3.patch, #17141
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup