bugFreeciv - Bugs: bug #20491, CMA cruft

Show feedback again

bug #20491: CMA cruft

Submitted by:  None
Submitted on:  Sun Feb 10 03:13:54 2013  
Category: agentsSeverity: 2 - Minor
Priority: 5 - NormalStatus: None
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenRelease: 
Operating System: AnyPlanned Release: 
Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Thu Mar 31 00:31:46 2016, comment #1:

README.cma is now README.governor for some years, and I'd know how to submit a patch if something is still wrong. This vintage 2013 nit can be closed.

Frank <dunnoob>
Sun Feb 10 03:13:54 2013, original submission:

The CMA help refers to the installed README.cma, and README.cma (vintage 2002) claims that clients/agents/cma_core.h explains how stuff actually works. There is a comment in cma_core.h:

| The plan defines a minimal surplus. The module will try to get the
| required surplus. If there are citizens free after allocation of
| the minimal surplus these citizens will get arranged to maximize
| the sum over base*factor. The base depends upon the factor_target.

However, factor_target is now a dummy, this comment should be updated. cma_core.h tries to include cm.h and attribute.h, I failed to find these files, maybe they are obsolete.

In README.cma all references to factor_target and cma_core.h can be removed. All vintage 2002 presets can be trimmed to eight values ending with FALSE,0 (or TRUE,0) instead of nine values ending with 0,0,1 (or 1,0,1).

The code in cma_fec.c (create_default_cma_presets, 2013) generates five CMA presets if no presets exist. These default presets should be listed in README.cma instead of the relevant old (2002) presets. Users need to know how to recreate deleted presets.

In the CMA GUI the six constraints permit to set the minimal surplus from -20 up to +20. There is no "trade deficit",
"luxury deficit", or "research deficit" in the default ruleset.

Please limit the minimal surplus to 0..20 if there are no plans
to introduce negative trade/luxury/research. Otherwise explain
in README.cma what a negative trade/luxury/research surplus is.

The difference between happiness and luxury is unclear. Please
explain in README.cma how happiness 1 over everything else 0 differs from luxury 1 over everything else 0.

Please explain also what the CMA celebration switch to the left
of happiness actually does or tries to do, i.e., how would a
user achieve this effect in manual micro-management without CMA.

So far I think that the CMA happiness factor and the celebration
switch are redundant, i.e., some combination of trade and luxury
should have the same effect. If it's not redundant I need more
than one fresh clue in README.cma what exactly the CMA does.

BTW, what is the base in "maximize the sum over base*factor"?



(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by dunnoob (Posted a comment)
  • -unavailable- added by None (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup