bugFreeciv - Bugs: bug #20492, PACKET_UNIT_INFO unused fields

 
 
Show feedback again

bug #20492: PACKET_UNIT_INFO unused fields

Submitted by:  pepeto <pepeto>
Submitted on:  Sun 10 Feb 2013 11:48:27 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: trunk r20790Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Feb 2013 01:04:25 PM UTC, SVN revision 22336:

Remove "changed_from_base" and "changed_from_road" fields from the PACKET_UNIT_INFO. They were not computed nor read anymore.

See gna bug #20492

(Browse SVN revision 22336)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 10 Feb 2013 11:48:27 AM UTC, original submission:

When working on the protocol cleanup, I noticed some errors about strange values inserted as 8-bits integers.

At r20790 for patch #3093, the fields "changed_from_base" and "changed_from_road" should have been renamed "changed_from_tgt_base" and "changed_from_tgt_road", but for some reasons, those weren't removed after inserting the new fields.

It results that the server read and send uninitialized data to the client. But the client doesn't handle them anyway.

Fix attached, needs capability string change.

pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17169:  packet_unused_fields.diff added by pepeto (407B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Feb 2013 01:04:45 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
      Planned Release2.5=>2.5.0
    Wed 13 Feb 2013 05:10:38 PM UTCpepetoAssigned toNone=>pepeto
    Sun 10 Feb 2013 11:48:27 AM UTCpepetoAttached File-=>Added packet_unused_fields.diff, #17169
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup