bugFreeciv - Bugs: bug #20507, Barbarian nations in unknown group...

 
 
Show feedback again

bug #20507: Barbarian nations in unknown group in civ2 ruleset

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 14 Feb 2013 01:22:15 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 11 Apr 2013 09:47:46 PM UTC, SVN revision 22718:

Copy Barbarians and Pirates to civ2 nationset to quell
'Unknown group "Core"' warnings.

See gna bug #20507.

(Browse SVN revision 22718)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 11 Apr 2013 09:42:53 PM UTC, SVN revision 22717:

Copy Barbarians and Pirates to civ2 nationset to quell
'Unknown group "Core"' warnings.

See gna bug #20507.

(Browse SVN revision 22717)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 09 Apr 2013 10:14:24 PM UTC, comment #3:

Attached patch copies relevant bits of barbarians/pirates.ruleset bodily into civ2/nations.ruleset to quell the warnings.

(civ2 nations seem to have only two leaders each, but I wasn't sure what the right thing was for barbarian nations, so I kept all the leaders.)

(file #17732)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 25 Mar 2013 10:41:46 AM UTC, comment #2:

> (Did civ2 even have pirates?)


Yes and no. civ/2 had just one barbarian nation that could attack either from land or sea. Freeciv has always had them as separate players. Hacks of earlier versions where those players shared same nation were very ugly and buggy, so we made separate "Pirate" nation for sea barbarians.

Marko Lindqvist <cazfi>
Project Administrator
Tue 19 Feb 2013 11:50:39 PM UTC, comment #1:

I think it's harmless. Certainly when I just tested civ2, I had no trouble running into pirates.

The obvious way to fix it is to fork barbarian/pirate nations, the same way all the other civ2 nations are forked. (Did civ2 even have pirates?)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 14 Feb 2013 01:22:15 AM UTC, original submission:

Loading civ2 ruleset with -d 3:
3: Nation Barbarian: Unknown group "Core".
3: Nation Pirate: Unknown group "Core".

I'm not sure if this has potential to cause any real harm in game when barbarians are supposed to appear.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17732:  trunk-S2_4-civ2-barbarians.patch added by jtn (2kB - text/x-diff - trunk/S2_4 r22707)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Apr 2013 09:48:09 PM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 09 Apr 2013 10:14:24 PM UTCjtnAttached File-=>Added trunk-S2_4-civ2-barbarians.patch, #17732
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
    Sat 06 Apr 2013 11:57:55 PM UTCjtnPlanned Release=>2.4.0,2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup