bugFreeciv - Bugs: bug #20512, Number of barbarian units created...

Show feedback again

bug #20512: Number of barbarian units created bugs

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri Feb 15 12:22:17 2013  
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Duplicate
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sun Oct 2 20:02:02 2016, comment #1:

Code has been rewritten in patch #5909

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Feb 15 12:22:17 2013, original submission:

- try_summon_barbarians() sets 'uprise' to 3 if player has more than UPRISE_CIV_MOST cities, but it does so only after old value (initialization to 1) of 'uprise' has already been used to decide number of barbarians to create
- if fc_rand(100) > get_player_bonus(victim, EFT_CIVIL_WAR_CHANCE), try_summon_barbarians() will not create any barbarians. That's probably opposite from what was meant - CIVIL_WAR_CHANCE of 100% will mean that fc_rand(100) can never be bigger than it whereas CIVIL_WAR_CHANCE of 0% means that barbarians are always created.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Oct 2 20:02:02 2016cazfiCategoryNone=>general
      Assigned toNone=>cazfi
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup