bugFreeciv - Bugs: bug #20534, Worklist glitch: unit icons bleed...

 
 
Show feedback again

bug #20534: Worklist glitch: unit icons bleed past their boundaries

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 19 Feb 2013 10:47:35 PM UTC  
 
Category: client-gtk-2.0Severity: 2 - Minor
Priority: 3 - LowStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: GNU/Linux
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 01 Apr 2013 03:14:00 PM UTC, comment #3:

> My guess would be you're hitting following documented case:
> When the destination rectangle contains parts not in the
> source image, the data at the edges of the source image is
> replicated to infinity.

(documented for instance here)

Thanks, yes, that's almost certainly it. So the trick is to avoid doing that.

Jacob Nevins <jtn>
Project Administrator
Wed 27 Feb 2013 06:25:38 PM UTC, comment #2:

Going deeper into the code, it could hint to a problem with gdk_pixbuf_composite in canvas_put_sprite, but hard to tell without more testing.

My guess would be you're hitting following documented case:

When the destination rectangle contains parts not in the source image, the data at the edges of the source image is replicated to infinity.
Unless there an off-by-one somewhere in that gdk-pixbuf code.

Rafał Mużyło <galtgendo>
Tue 19 Feb 2013 10:48:23 PM UTC, comment #1:

(FWIW, my previous notes on the issue in their entirety: "client/gui-gtk-2.0/wldlg.c:cell_render_func()". Make of that what you will.)

Jacob Nevins <jtn>
Project Administrator
Tue 19 Feb 2013 10:47:35 PM UTC, original submission:

This is very cosmetic, but it's been bothering me for years.

In the worklist, unit icons which have pixels set at their vertical edges have those pixel columns "bled" out into bands horizontally.

See attached screenshot of Freight, and also bug #15777's file #8785 for a previous example.

In Amplio/2 I think unit icons are a little narrower than building/wonder icons, which force column width; I'm guessing that something is extending the unit icon to match the containing cell in a sub-optimal way. Really we just want whitespace padding.

Dunno if this is specific to OS (Ubuntu 10.04.4), window environment (GNOME, Compiz), theme (Freeciv for client, Ambiance for desktop), ... It's been with me with the gtk2 client for at least three years, probably longer.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17267:  worklist_glitch_freight.png added by jtn (10kB - image/png - Glitch in city worklist, trunk r22387)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 Feb 2013 10:47:35 PM UTCjtnAttached File-=>Added worklist_glitch_freight.png, #17267
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup