bugFreeciv - Bugs: bug #20535, Road icons in editor are a bit ugly

 
 
Show feedback again

bug #20535: Road icons in editor are a bit ugly

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 19 Feb 2013 10:56:03 PM UTC  
 
Category: editorSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: GNU/Linux
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Nov 2013 10:15:40 PM UTC, SVN revision 23735:

Fixed the wrong offsets of the road sprites when building road type icon.

Reported by Jacob Nevins

See bug #20535

(Browse SVN revision 23735)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 15 Nov 2013 10:15:35 PM UTC, SVN revision 23734:

Fixed the wrong offsets of the road sprites when building road type icon.

Reported by Jacob Nevins

See bug #20535

(Browse SVN revision 23734)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 08 Nov 2013 12:02:42 AM UTC, comment #2:

These patches fix the wrong offsets of the road sprites.

(file #19335, file #19336)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 20 Feb 2013 08:58:30 AM UTC, comment #1:

"a bit"? What we currently have is what I managed to get working in order of that icon issue not to block all of gen-road development. It should have been quite straight-forward conversion from old way of producing road icons (=when fixing this, pre-gen-road code might be worth checking for reference) but for some reason it didn't work the same at all.
Once the icon is centered, it will probably make sense to draw just one or two of the road segments - currently all are drawn to make sure something gets drawn down from the very top part of the icon.

I'm just about to commit patch #3709 what adds icons for river road types. It suffers many of the same problems as existing road icons, but again, let me go forward with river road types.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 19 Feb 2013 10:56:03 PM UTC, original submission:

See attachment.

  • They seem to be off-centre
  • They suffer from the same "bleeding" problem as bug #20534, only vertically

Obviously not vital, but would be nice to fix.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19335:  EditorRoadIcons.patch added by cazfi (1kB - text/x-diff)
file #17268:  editor_roads.png added by jtn (19kB - image/png - screenshot of road selection in gtk2 editor, trunk r22387)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Nov 2013 10:15:50 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 08 Nov 2013 12:02:42 AM UTCcazfiAttached File-=>Added EditorRoadIcons.patch, #19335
      Attached File-=>Added EditorRoadIcons-S2_5.patch, #19336
      StatusNone=>Ready For Test
      Planned Release2.5.0=>2.5.0, 2.6.0
    Wed 20 Feb 2013 08:58:30 AM UTCcazfiSeverity2 - Minor=>3 - Normal
    Tue 19 Feb 2013 10:56:03 PM UTCjtnAttached File-=>Added editor_roads.png, #17268
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup