bugFreeciv - Bugs: bug #20538, Numerous assertion failures when...

 
 
Show feedback again

bug #20538: Numerous assertion failures when loading an old savegame

Submitted by:  pepeto <pepeto>
Submitted on:  Wed Feb 20 10:58:33 2013  
 
Category: generalSeverity: 5 - Blocker
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: trunk r22403Operating System: Any
Planned Release: 2.4.3, 2.5.0-beta1, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat Jul 19 09:21:16 2014, SVN revision 25622:

Set up citizen nationality information when loading pre-2.3 savegame

Reported by pepeto

See bug #20538

(Browse SVN revision 25622)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Jul 19 09:21:05 2014, SVN revision 25621:

Set up citizen nationality information when loading pre-2.3 savegame

Reported by pepeto

See bug #20538

(Browse SVN revision 25621)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Jul 19 09:20:59 2014, SVN revision 25620:

Set up citizen nationality information when loading pre-2.3 savegame

Reported by pepeto

See bug #20538

(Browse SVN revision 25620)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jul 17 21:27:12 2014, comment #8:

The other bug, now confirmed, in bug #22360

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jul 17 21:04:05 2014, comment #7:

Original report was about savegame.c problem (as version was 20105). My speculation about problems in savegame2.c when nationality has been enabled in a ruleset post-2.4 should go to new ticket if there really is such an bug (to be confirmed)

Attached is a fix for the bug of this ticket.

(file #21453, file #21454)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jul 16 22:34:34 2014, comment #6:

Still happens with trunk/S2_5 r25592.

This is a little different than bug #22350, since it's a pre-savegame2 savegame. Guessing that lack of nationality isn't handled as cleanly in savegame.c as savegame2.c?

Jacob Nevins <jtn>
Project Administrator
Tue Jul 15 19:39:22 2014, comment #5:

See also bug #22350.

Jacob Nevins <jtn>
Project Administrator
Mon May 6 22:18:23 2013, comment #4:

2.4 / experimental ruleset is not affected as nationality as new feature in 2.4 is handled by 2.3 to 2.4 savegame format compatibility function.
So, the problem is only rulesets that have no nationality in 2.4, but enable it in later versions, such as classic ruleset in 2.5

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Mar 24 22:25:05 2013, comment #3:

If it really is about ruleset having nationality enabled savegame loading time, but not when it was saved, classic ruleset will be affected only beginning in 2.5, but it might affect other rulesets in 2.4 already (if they enable nationality) - such as experimental ruleset.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Feb 20 11:59:18 2013, comment #2:

> Is that classic ruleset? Nationality got enabled in that
> ruleset recently, so presumably savegame was created when
> ruleset has no nationality, but at loading time it has.


Yes, savegame says version=20105, rulesetdir="default".

pepeto <pepeto>
Project Member
Wed Feb 20 11:05:32 2013, comment #1:

Is that classic ruleset? Nationality got enabled in that ruleset recently, so presumably savegame was created when ruleset has no nationality, but at loading time it has.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Feb 20 10:58:33 2013, original submission:

I tried to load file #7060 for testing bug #16643.

I got on server side:

On client side:

pepeto <pepeto>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Jul 19 09:21:34 2014cazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu Jul 17 21:04:05 2014cazfiAttached File-=>Added SavegameCNationalityFixIt.patch, #21453
      Attached File-=>Added SavegameCNationalityFixIt-S2_4.patch, #21454
      StatusNone=>Ready For Test
      Planned Release2.5.0, 2.6.0=>2.4.3, 2.5.0-beta1, 2.6.0
    Tue Jul 15 16:24:38 2014cazfiCategoryNone=>general
      Severity3 - Normal=>5 - Blocker
      Planned Release=>2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup