bugFreeciv - Bugs: bug #20543, lua error: Execution time limit...

 
 
Show feedback again

bug #20543: lua error: Execution time limit exceeded in script

Submitted by:  pepeto <pepeto>
Submitted on:  Wed 20 Feb 2013 03:13:33 PM UTC  
 
Category: rulesetsSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: trunk r22403Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 07 Mar 2013 08:17:00 AM UTC, comment #7:

I've committed the patch, but given the parameters Pepeto had, there might be more than inefficiency to this issue (or problems with bug maps even after this patch), so leaving ticket open for now.

Marko Lindqvist <cazfi>
Project Administrator
Thu 07 Mar 2013 08:13:59 AM UTC, SVN revision 22495:

Reorganized lua code to add map labels to make it significantly faster.

Too long script execution time reported by pepeto

See bug #20543

(Browse SVN revision 22495)

Marko Lindqvist <cazfi>
Project Administrator
Thu 28 Feb 2013 02:04:50 PM UTC, comment #5:

Randomness issue seems to be there regardless of the patch, so I'm about to commit it.

Marko Lindqvist <cazfi>
Project Administrator
Tue 26 Feb 2013 04:43:30 PM UTC, comment #4:

Testing my patch I've noticed that there's something wrong with the supposed randomness of it. Every map I create has "Scorched Spot" and "Deep Trench" and no other labels while each label should appear with same probability.

Marko Lindqvist <cazfi>
Project Administrator
Thu 21 Feb 2013 09:46:23 AM UTC, comment #3:

> Starting game with big map?


It was on a map of size=5, landmass=30 for 10 players.

pepeto <pepeto>
Project Member
Thu 21 Feb 2013 09:12:47 AM UTC, comment #2:

Attached patch should be much more efficient way to place labels on map.

Place all the labels in one whole_map_iterate instead of separate whole_map_iterate for each terrain type to be labeled.

(file #17303)

Marko Lindqvist <cazfi>
Project Administrator
Thu 21 Feb 2013 09:00:01 AM UTC, comment #1:

Starting game with big map?

Marko Lindqvist <cazfi>
Project Administrator
Wed 20 Feb 2013 03:13:33 PM UTC, original submission:

Got it with classic ruleset:

pepeto <pepeto>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17303:  MapLabelingSpeedup.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 01 Apr 2013 03:07:30 PM UTCjtnPlanned Release=>2.5.0
    Thu 07 Mar 2013 08:17:00 AM UTCcazfiStatusReady For Test=>None
    Tue 05 Mar 2013 12:03:07 AM UTCjtnDependencies-=>bugs #20588 is dependent
    Thu 21 Feb 2013 09:12:47 AM UTCcazfiAttached File-=>Added MapLabelingSpeedup.patch, #17303
      CategoryNone=>rulesets
      StatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup