Freeciv - Bugs: bug #20551, failed to compile luasql: not... [Gna!]

Freeciv - Bugs: bug #20551, failed to compile luasql: not...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Patches
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search

Show feedback again

bug #20551: failed to compile luasql: not compatible with Lua 5.2

Submitted by:	Lavrentij P Berija <heilkitty>
Submitted on:	Sun 24 Feb 2013 07:16:27 AM UTC

Category:	general	Severity:	3 - Normal
Priority:	5 - Normal	Status:	Fixed
Assigned to:	Marko Lindqvist <cazfi>	Open/Closed:	Closed
Release:	trunk r22434	Operating System:	GNU/Linux
Planned Release:	2.5.0

Add a New Comment (Rich Markup):

You are not logged in

Please log in, so followups can be emailed to you.

( Jump to the original submission)

Tue 05 Mar 2013 07:19:03 AM UTC, SVN revision 22474: Updated luasql to version from v2.3.0 git tag to fix build against lua-5.2. Reported by Lavrentij P Berija See bug #20551 (Browse SVN revision 22474)	Marko Lindqvist <cazfi>
Mon 04 Mar 2013 09:29:13 PM UTC, comment #11: file #17357 fixes the bug for me; see also svn 2.5 at https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv	Matthias Pfafferodt <syntron>
Wed 27 Feb 2013 07:13:20 AM UTC, comment #10: No caller expects return value, so making the return value void. I'm more worried about the fact that this didn't turn out as error in my build. Despite -Werror it shows it just as an warning. (file #17357)	Marko Lindqvist <cazfi>
Wed 27 Feb 2013 12:17:31 AM UTC, comment #9: (Erm, I should have said that's in dependencies/luasql-2.1.1/src/ls_mysql.c.)	Jacob Nevins <jtn>
Wed 27 Feb 2013 12:16:46 AM UTC, comment #8: Applying the patch (file #17336) I get cc1: warnings being treated as errors ls_mysql.c: In function ‘cur_nullify’: ls_mysql.c:193: error: no return statement in function returning non-void And indeed that appears to be true. The whole function cur_nullify() is new in the patch. (My normal build has SQLite and MySQL backends enabled, but not PostgreSQL).	Jacob Nevins <jtn>
Mon 25 Feb 2013 10:05:48 AM UTC, comment #7: ...issue 7 claims that 2.4.0 exists (haven't checked)...	Jacob Nevins <jtn>
Mon 25 Feb 2013 09:44:16 AM UTC, comment #6: Attached patch updates our copy of luasql parts to ones found from v2.3.0 git tag. For simplicity of this patch I've left directory rename to future ticket. File "Version" has been added to describe what the version actually is. (file #17336)	Marko Lindqvist <cazfi>
Mon 25 Feb 2013 09:35:51 AM UTC, comment #5: So, they have no tarballs at all. README's (in our luasql-2.1.1 directory, and in their latest tree) refer itself as luasql-2.1, homepage says 2.2 is the latest, git has no 2.2 tag but has 2.3 tag...	Marko Lindqvist <cazfi>
Sun 24 Feb 2013 08:47:14 AM UTC, comment #4: > undefined symbol: rl_attempted_completion_function We've seen that before, I think: bug #19859	Marko Lindqvist <cazfi>
Sun 24 Feb 2013 08:45:52 AM UTC, comment #3: > backport from luasql development version if required changes are > there I think we could adapt parts of this commit: https://github.com/keplerproject/luasql/commit/21eb9b968c44c7f44ebf8686153d91e15c84b874	Marko Lindqvist <cazfi>
Sun 24 Feb 2013 08:39:21 AM UTC, comment #2: Compiled luasql from git ( https://github.com/keplerproject/luasql ). fcser throws an error ~/soft/freeciv/trunk/server/.libs/lt-freeciv-server: symbol lookup error: ~/soft/freeciv/trunk/server/.libs/libfreeciv-srv.so.0: undefined symbol: rl_attempted_completion_function whether I build with readline support or not. Is that a separate bug?	Lavrentij P Berija <heilkitty>
Sun 24 Feb 2013 07:26:56 AM UTC, comment #1: I had forgotten that luasql gets built only when auth is in use, so its build with lua-5.2 was never tested. I were just surprised that it caused no problems in my testing! There seems to be no lua-5.2 compatible version of luasql available. Our options seem to be hack luasql ourselves (or to backport from luasql development version if required changes are there) or to revert to lua-5.1.	Marko Lindqvist <cazfi>
Sun 24 Feb 2013 07:16:27 AM UTC, original submission: make[4]: Entering directory `~/soft/freeciv/trunk/dependencies/luasql-2.1.1/src' CC luasql.lo In file included from luasql.c:15:0: luasql.h:24:1: error: unknown type name 'luaL_reg' luasql.c:46:1: error: unknown type name 'luaL_reg' luasql.c: In function 'luasql_createmeta': luasql.c:51:2: error: implicit declaration of function 'luaL_openlib' [-Werror=implicit-function-declaration] luasql.c:51:2: error: nested extern declaration of 'luaL_openlib' [-Werror=nested-externs] luasql.c:55:2: error: request for member 'func' in something not a structure or union cc1: all warnings being treated as errors make[4]: * [luasql.lo] Error 1 make[4]: Leaving directory `~/soft/freeciv/trunk/dependencies/luasql-2.1.1/src' make[3]: * [all-recursive] Error 1 make[3]: Leaving directory `~/soft/freeciv/trunk/dependencies/luasql-2.1.1' make[2]: * [all-recursive] Error 1 make[2]: Leaving directory `~/soft/freeciv/trunk/dependencies' make[1]: * [all-recursive] Error 1 make[1]: Leaving directory `~/soft/freeciv/trunk' make: *** [all] Error 2 OS: Ubuntu 12.04 ./configure options: --enable-fcdb=sqlite3 --enable-ipv6=yes --enable-svnrev --enable-aimodules=yes --enable-debug=yes --enable-gprof --enable-sys-lua --with-readline --enable-shared (With freeciv embedded lua - the same thing.)	Lavrentij P Berija <heilkitty>

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Comment:

Attached Files

file #17357: LuasqlEffect230-2.patch.bz2 added by cazfi (9kB - application/x-bzip)

file #17336: LuasqlEffect230.patch.bz2 added by cazfi (9kB - application/x-bzip)

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by syntron (Posted a comment)

-unavailable- added by jtn (Updated the item)

-unavailable- added by cazfi (Posted a comment)

-unavailable- added by heilkitty (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 8 latest changes.

Date	Changed By	Updated Field	Previous Value	Replaced By
Tue 05 Mar 2013 07:19:17 AM UTC	cazfi	Status	Ready For Test	Fixed
		Assigned to	None	cazfi
		Open/Closed	Open	Closed
Wed 27 Feb 2013 07:13:20 AM UTC	cazfi	Attached File	-	Added LuasqlEffect230-2.patch.bz2, #17357
Mon 25 Feb 2013 09:44:16 AM UTC	cazfi	Attached File	-	Added LuasqlEffect230.patch.bz2, #17336
		Status	None	Ready For Test
		Planned Release		2.5.0
Sun 24 Feb 2013 09:38:46 AM UTC	jtn	Summary	failed to compile luasql	failed to compile luasql: not compatible with Lua 5.2

Show feedback again