bugFreeciv - Bugs: bug #20555, Client fails to kill server when...

 
 
Show feedback again

bug #20555: Client fails to kill server when it fails to get 'hack' access

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 24 Feb 2013 01:10:31 PM UTC  
 
Category: clientSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.3.5,2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 06 Mar 2013 10:32:53 PM UTC, SVN revision 22490:

If the client fails to get 'hack' access to its spawned server, shut it
down forcibly rather than trying '/quit' (which needs hack).

See gna bug #20555.

(Browse SVN revision 22490)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 06 Mar 2013 10:28:16 PM UTC, SVN revision 22488:

If the client fails to get 'hack' access to its spawned server, shut it
down forcibly rather than trying '/quit' (which needs hack).

See gna bug #20555.

(Browse SVN revision 22488)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Wed 06 Mar 2013 10:24:18 PM UTC, SVN revision 22486:

If the client fails to get 'hack' access to its spawned server, shut it
down forcibly rather than trying '/quit' (which needs hack).

See gna bug #20555.

(Browse SVN revision 22486)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 05 Mar 2013 01:19:46 AM UTC, comment #1:

Patch attached.
In S2_3 version, string change split out to separate patch, to be applied if we decide to break string freeze on S2_3 for a future release.

(file #17389, file #17390, file #17391)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 24 Feb 2013 01:10:31 PM UTC, original submission:

Noted in bug #18467 ("bug 2"):

If the client's handle_single_want_hack_reply() finds that hack is denied for some reason, it says "Failed to obtain the required access level to take control of the server. The server will now be shutdown." But the server is not shut down.

I think this is because client_kill_server() tries to do "/quit" if the connection to the server is still up. But "/quit" requires hack access...

I think it would be sufficient to add a "client_has_hack" test in client_kill_server(), which will push it down the process-kill path. (But I haven't tested it.)

(Also the message should probably say "attempting to shut down", as if you didn't get hack you might not be able to shut it down either, say if you've somehow connected to a server you didn't start.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17389:  trunk-S2_4-client-spawn-hack-fail.patch added by jtn (2kB - text/x-diff - trunk/S2_4/S2_3 r22473)
file #17390:  S2_3-client-spawn-hack-fail.patch added by jtn (2kB - text/x-diff - trunk/S2_4/S2_3 r22473)
file #17391:  S2_3-client-spawn-hack-fail-msg.patch added by jtn (825B - text/x-diff - trunk/S2_4/S2_3 r22473)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 06 Mar 2013 10:35:00 PM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 05 Mar 2013 01:19:46 AM UTCjtnAttached File-=>Added trunk-S2_4-client-spawn-hack-fail.patch, #17389
      Attached File-=>Added S2_3-client-spawn-hack-fail.patch, #17390
      Attached File-=>Added S2_3-client-spawn-hack-fail-msg.patch, #17391
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
      Planned Release=>2.3.5,2.4.0,2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup