bugFreeciv - Bugs: bug #20561, Allow server messages to be...

 
 
Show feedback again

bug #20561: Allow server messages to be translated to client's locale

Submitted by:  Oleg <o01eg>
Submitted on:  Tue 26 Feb 2013 10:07:53 AM UTC  
 
Category: generalSeverity: 1 - Wish
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 01 Apr 2013 03:05:36 PM UTC, comment #5:

Well, yes, client-side localisation would require network changes.

I think there's the germ of an idea here, but I'm still convinced that if we go to the effort of making per-client localised server messages possible at all, then the right place to actually translate them is on the server, not the client. Retitling accordingly.

Jacob Nevins <jtn>
Project Administrator
Wed 06 Mar 2013 05:47:03 AM UTC, comment #4:

> I don't see anything relevant in r22161 -- did you mean another revision?


This revesion adds the packet about tech gained.

What if use it instead sending string and store in the message queue as serialized packets?

Oleg <o01eg>
Tue 05 Mar 2013 12:12:01 AM UTC, comment #3:

I don't see anything relevant in r22161 -- did you mean another revision?

I think that either client-side or server-side-client-specific localisation would require all construction of strings from localisable parts to be done by "approved" means, and format strings and arguments kept in some unflattened data structure until fan-out to invididual clients in low-level functions; so that requires a massive audit, and those functions need to be capable of all the compositions that we want (that are currently happening in ad-hoc ways in situation-specific code); and probably there are tedious memory ownership and freeing issues to worry about. So I can't see us getting around to it, to be honest.

But if you are going to all that trouble, I think the server-side localisation is clearly superior.

> Is modpack-specific text can be translated now?

Well, um. A keen server operator could certainly add modpack strings to the message catalogue used by the server. I don't know that any do.

Jacob Nevins <jtn>
Project Administrator
Tue 26 Feb 2013 01:18:19 PM UTC, comment #2:

What if send client packet with arguments instead the format string like here http://svn.gna.org/viewcvs/freeciv?view=revision&revision=22161

Is modpack-specific text can be translated now?

Oleg <o01eg>
Tue 26 Feb 2013 10:41:39 AM UTC, comment #1:

I've thought about this. Not really practical; consider messages that are currently constructed out of bits (unit names, numbers, ...) on the server and sent as single strings to the client; you'd need to send the format string and arguments to the client to be localised and assembled there; changing any text on the server will lead to incomplete localisation on clients that aren't exactly the same version (unless we somehow keep strings from old servers in the localisations for new clients); any modpack-specific text can currently be localised in one place on the server would remain unlocalised unless you managed to deploy translations to everyone's client; and so on.

Another option I've considered is having the client tell the server its locale, and have the server give clients messages in their own locale. I think that's easier than the above, but still fraught; you have to refrain from flattening format strings until the fan-out to individual clients so that you can send different strings to different clients; text saved in savefiles (event cache) is hard; etc.

Jacob Nevins <jtn>
Project Administrator
Tue 26 Feb 2013 10:07:53 AM UTC, original submission:

If server and clients have different locales messages display in server's locale instead client's.

What about move all translationable strings from the server to clients what allows players with different locales get fully translated game?

Oleg <o01eg>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by o01eg (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 01 Apr 2013 03:05:36 PM UTCjtnRelease2.5.0=>
      SummaryMove translations from freeciv-server to the clients.=>Allow server messages to be translated to client's locale
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup