bugBattle for Wesnoth - Bugs: bug #20562, A few keys in [side] stopped...

 
 
Show feedback again

bug #20562: A few keys in [side] stopped working

Submitted by:  None
Submitted on:  Tue 26 Feb 2013 03:35:22 PM UTC  
 
Category: BugSeverity: 2 - Minor
Priority: 3 - LowItem Group: Multiplayer Lobby
Status: NonePrivacy: Public
Assigned to: Andrius Silinskas <thunderstruck>Originator Email: -unavailable-
Open/Closed: OpenRelease: 1.11.1+svn
Operating System: windows 7

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 11 Apr 2014 06:32:50 PM UTC, comment #1:

"The gender, type, and faction keys no longer lock in the player to that choice or even do anything at all."
This claim isn't exactly true, because keys do work, but not all the time. faction and gender keys didn't do nothing if force_lock_settings wasn't set to yes, while type key seemed to work just fine.

I've fixed this with https://github.com/wesnoth/wesnoth/commit/cec331c11b4d85f7f37b127d0373e14a76b6d475

I made it so that faction and gender attributes provide default values for relevant combos even if force_lock_settings is not set to yes.

To fully fix this one, I think we should add such attributes as faction_lock to provide individual locks for factions, leaders and genders.

I'm lowering priority of this one, because the problem has been already mostly addressed.

Andrius Silinskas <thunderstruck>
Project MemberIn charge of this item.
Tue 26 Feb 2013 03:35:22 PM UTC, original submission:

The gender, type, and faction keys no longer lock in the player to that choice or even do anything at all.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by thunderstruck (Posted a comment)
  • -unavailable- added by jamit (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Apr 2014 06:32:50 PM UTCthunderstruckSeverity3 - Normal=>2 - Minor
      Priority5 - Normal=>3 - Low
      Assigned toNone=>thunderstruck
    Mon 22 Jul 2013 12:01:00 AM UTCjamitItem Group None of the others=>Multiplayer Lobby
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup