bugFreeciv - Bugs: bug #20576, Trait "Aggressive" uses...

 
 
Show feedback again

bug #20576: Trait "Aggressive" uses non-standard scale in default AI.

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 27 Feb 2013 05:14:32 PM UTC  
 
Category: aiSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 21 Sep 2013 09:59:21 PM UTC, SVN revision 23467:

Adjusted scale of AI trait "Aggressive" values so that min, default, and max values
make better sense.

See bug #20576

(Browse SVN revision 23467)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 21 Sep 2013 09:59:13 PM UTC, SVN revision 23466:

Adjusted scale of AI trait "Aggressive" values so that min, default, and max values
make better sense.

See bug #20576

(Browse SVN revision 23466)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 18 Sep 2013 12:23:02 AM UTC, comment #2:

Patch to adjust the scale and to set default value of 50 to use in supplied rulesets.

(file #19039)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 08:14:54 PM UTC, comment #1:

Problem here preventing something like simple use of factor 3 (to make 50 -> 150) is that this value is used in more like exponential than linear fashion, so to have max value of 2500 to translate as 2500 * 3 = 7500 instead of just 2500 would be insanely out of proportions.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 05:14:32 PM UTC, original submission:

AI trait "aggressive" does not nicely fit to same scale than other traits in default AI. As a result its default value is set to 150 when all other trait values are 50 in all supplied rulesets.
That would be barely acceptable solution if we supported only default ai module. But we certainly cannot make that ugliness part of ai module interface, to say: "All AI modules have to be implemented so that trait aggressive gets weird scale different from all other traits, since that's what default ai does and all rulesets AI module might be used with expect that. No clean trait value scale implementations allowed."

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19039:  StdScaleAggressive.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 21 Sep 2013 09:59:31 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 18 Sep 2013 12:23:02 AM UTCcazfiAttached File-=>Added StdScaleAggressive.patch, #19039
      StatusNone=>Ready For Test
      Planned Release2.5.0=>2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup