bugBattle for Wesnoth - Bugs: bug #20581, Sound in additional frames has...

 
 
Show feedback again

bug #20581: Sound in additional frames has wrong start time

Submitted by:  David Mikos <coffee>
Submitted on:  Sun 03 Mar 2013 11:16:19 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: WML
Status: FixedPrivacy: Public
Assigned to: David Mikos <coffee>Open/Closed: Closed
Release: 1.11.1+svn(56433M)Operating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 10 Mar 2013 09:10:44 PM UTC, comment #1:

Fixed in revision 56478.

Problem was that frames without a duration were set to 0 and sound not started.

A duration 1 dummy frame must also be put before the sound to get the desired effect.

David Mikos <coffee>
Project MemberIn charge of this item.
Sun 03 Mar 2013 11:16:19 AM UTC, original submission:

Hi

The macro under utils/sound-utils.cfg -- SOUND:HIT_AND_MISS, which I would like to make more use of (see http://forums.wesnoth.org/viewtopic.php?f=10&t=38198&start=30) does not work as intended.

If any additional frame is created, the start time is wrongly set to the main frame start time. This affects the orcish assassin, etc. that already use this macro, but it's use could be widened to many other units to simplify yet again the WML speficiation for the animations.

Is the related code under unit_animation.cpp under particule? Maybe I can help to bug fix this?

David Mikos <coffee>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by coffee (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:24:41 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 10 Mar 2013 09:10:44 PM UTCcoffeeStatusNone=>Fixed
      Assigned toNone=>coffee
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup