bugBattle for Wesnoth - Bugs: bug #20582, [era] and [modification] WML is...

 
 
Show feedback again

bug #20582: [era] and [modification] WML is copied twice for MP campaign

Submitted by:  FAAB <faabumc>
Submitted on:  Mon 04 Mar 2013 04:42:32 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer
Status: FixedPrivacy: Public
Assigned to: B. Lipka <lipk>Open/Closed: Open
Release: 1.11 (rev 56435)Operating System: GNU/linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 03 Dec 2014 03:03:12 AM UTC, comment #7:

events from modification beeing present in all scenarios of a campaign is the expected behaviour, at least in 1.13.

I refactored the playcampaign.cpp code in 1.13 and if there was a bug with events from modification beeing alied twice in one scenario it is not there (in 1.13) anymore.

marking as fixed.

Daniel <gfgtdf>
Project Member
Wed 24 Apr 2013 01:58:03 AM UTC, comment #6:

I will try but I am lagging a bit behind to latest SVN version r56594.

FAAB <faabumc>
Project Member
Mon 18 Mar 2013 11:43:33 AM UTC, comment #5:

I can't reproduce the problem. Would you please post a test case?

B. Lipka <lipk>
Project MemberIn charge of this item.
Tue 12 Mar 2013 08:30:11 AM UTC, comment #4:

As expected the proposed fix does not work.

The test it was working OK was due to conflicting macro definitions in different add-ons.

FAAB <faabumc>
Project Member
Mon 11 Mar 2013 08:48:40 PM UTC, comment #3:

I can hardly imagine that that patch would be a solution. It only reverts my last commit in the area, basically restoring the old state which you said was broken (and I experienced the same).

Feel free to reassign this bug to yourself, I have very limited time for Wesnoth now.

B. Lipka <lipk>
Project MemberIn charge of this item.
Wed 06 Mar 2013 01:30:56 AM UTC, comment #2:

Hi lipk, it seems that if I do a "svn merge -c -56181 ." based on revision 56435, it seems to be working fine for me.

I mean:
- at scenario 1, the [modification] WML is copied only once in level
- at scenario 2, the [modification] events are still active.

I an unsure how this result is different from the early version where [modification] where not activated on scenario 2.
I did not commit the svne revert as you might want to test it is OK for your too.

FAAB <faabumc>
Project Member
Mon 04 Mar 2013 11:43:46 AM UTC, comment #1:

Ok this is got broken when I fixed events not copying into later scenarios at all. Hopefully in the next iteration we'll have the correct number of copies ;)

B. Lipka <lipk>
Project MemberIn charge of this item.
Mon 04 Mar 2013 04:42:32 AM UTC, original submission:

When starting a MP campaign with modification, the events from the [modification] are copied twice to level WML for scenario 1.

As a consequence, when defining an array by appending elements in [modification] variables, the resulting array has double the expected size.

src/multiplayer_connect.cpp line 1837
src/playcampaign.cpp line 101

FAAB <faabumc>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17418:  20582.diff added by faabumc (1kB - text/x-patch - Proposed revert at comment #3)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gfgtdf (Posted a comment)
  • -unavailable- added by lipk (Posted a comment)
  • -unavailable- added by faabumc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 03 Dec 2014 03:03:12 AM UTCgfgtdfStatusNone=>Fixed
    Mon 11 Mar 2013 01:04:37 AM UTCfaabumcAttached File-=>Added 20582.diff, #17418
    Mon 04 Mar 2013 11:43:46 AM UTClipkAssigned toNone=>lipk
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup