bugFreeciv - Bugs: bug #20585, variable 'punit' set but not used...

 
 
Show feedback again

bug #20585: variable 'punit' set but not used in citytools.c

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Mon 04 Mar 2013 09:35:16 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Matthias Pfafferodt <syntron>Open/Closed: Closed
Release: S2_4 svn22473Operating System: None
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 20 Apr 2013 01:25:47 PM UTC, SVN revision 22734:

remove NDEBUG from mysql cflags if set as '-DNDEBUG'

this is the case for opensuse 12.3+

see gna bug #20585

(Browse SVN revision 22734)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Sat 20 Apr 2013 01:25:29 PM UTC, SVN revision 22733:

remove NDEBUG from mysql cflags if set as '-DNDEBUG'

this is the case for opensuse 12.3+

see gna bug #20585

(Browse SVN revision 22733)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Sat 06 Apr 2013 04:15:50 PM UTC, comment #3:

the attached patch removes the compiler option NDEBUG from the mysql CFLAGS - building finishes now without problems. Can it be applied?

(file #17687)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Wed 03 Apr 2013 06:33:40 PM UTC, comment #2:

I found the reason for the error in the mysql (mariadb) CFLAGS - they contain a definition of NDEBUG. How to process here?

(file #17669)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Mon 04 Mar 2013 09:58:30 PM UTC, comment #1:

Well, I could see this could happen if DEBUG and NDEBUG were both defined.

Our configure stuff should only define NDEBUG with --enable-debug=no. Is it possible that the environment defines NDEBUG?

Jacob Nevins <jtn>
Project Administrator
Mon 04 Mar 2013 09:35:16 PM UTC, original submission:

I get the following error on opensuse 12.3 (see https://build.opensuse.org/package/live_build_log?arch=x86_64&package=freeciv-2.4svn&project=home%3Asyntron%3Afreeciv&repository=openSUSE_12.3_Update_standard). The build uses '--enable-debug=yes'.

It's the following code:

opensuse 12.3 will be released on 13.03. I do not know which additional test is activated there ...

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17669:  config.log added by syntron (205kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by syntron (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 20 Apr 2013 01:26:10 PM UTCsyntronStatusReady For Test=>Fixed
      Assigned toNone=>syntron
      Open/ClosedOpen=>Closed
    Sat 06 Apr 2013 04:15:50 PM UTCsyntronAttached File-=>Added 0001-remove-NDEBUG-from-mysql-cflags.patch, #17687
      StatusNone=>Ready For Test
    Wed 03 Apr 2013 06:33:40 PM UTCsyntronAttached File-=>Added config.log, #17669
    Mon 04 Mar 2013 09:46:42 PM UTCjtnReleasesvn22473=>S2_4 svn22473
      Planned Release=>2.4.0,2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup