bugFreeciv - Bugs: bug #20599, Boolean sounding name...

 
 
Show feedback again

bug #20599: Boolean sounding name "is_blended" for integer field

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 07 Mar 2013 10:57:51 AM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 28 Mar 2013 08:30:22 PM UTC, SVN revision 22616:

Renamed tileset field "is_blended" as "blend_layer" as it's not boolean value.

See bug #20599

(Browse SVN revision 22616)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 25 Mar 2013 10:24:23 AM UTC, comment #1:

Patch to rename "is_blended" as "blend_layer"

(file #17538)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 07 Mar 2013 10:57:51 AM UTC, original submission:

Tileset has "is_blended" fields that are actually integers telling layer number. That should be renamed so that one does not assume them to be boolean (guess who just broke his tilesets by setting those to FALSE / TRUE)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17538:  BlendLayer.patch added by cazfi (16kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 28 Mar 2013 08:30:35 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 25 Mar 2013 10:24:22 AM UTCcazfiAttached File-=>Added BlendLayer.patch, #17538
      CategoryNone=>client
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup