bugFreeciv - Bugs: bug #20618, Goto shouldn't attack in fogged...

 
 
Show feedback again

bug #20618: Goto shouldn't attack in fogged tiles

Submitted by:  None
Submitted on:  Wed 13 Mar 2013 11:47:09 PM UTC  
 
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 2.3.3
Operating System: NonePlanned Release: 2.4.4, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 07 Sep 2014 07:54:57 AM UTC, SVN revision 26259:

Made the server able to identify if the unit orders sent by the client would
be end by an action such as attack, establishing trade route etc. If not,
check last move to ensure the unit will not attack undesired tiles.

Reported anonymously

See gna bug #20618

(Browse SVN revision 26259)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 07 Sep 2014 07:54:52 AM UTC, SVN revision 26258:

Made the server able to identify if the unit orders sent by the client would
be end by an action such as attack, establishing trade route etc. If not,
check last move to ensure the unit will not attack undesired tiles.

Reported anonymously

See gna bug #20618

(Browse SVN revision 26258)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 07 Sep 2014 07:54:44 AM UTC, SVN revision 26257:

Added unit ORDER_ACTION_MOVE to specify to the server we don't only move to
the last tile of the patch. We also want attack, establish trade route etc.

Reported anonymously

See gna bug #20618

(Browse SVN revision 26257)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 05 Sep 2014 08:09:13 AM UTC, comment #5:

New version for S2_4 and S2_5:

  • Respect tabular format in savegames.

(file #22039, file #22040)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 03 Sep 2014 03:46:57 PM UTC, comment #4:

New version for trunk. Added version for S2_4 and S2_5.

(file #22011, file #22012, file #22013)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 02 Sep 2014 01:13:39 PM UTC, comment #3:

When loading a <=2.5 savegame, it may results that a unit attack in the middle of the path. It needs more work before committing.

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 02 Sep 2014 08:37:51 AM UTC, comment #2:

Implementation attached. Need network capability string refresh.

(file #21997)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 06 Jul 2014 01:32:05 PM UTC, comment #1:

I see two ways to implements this:

  • add a client goto option to have 'vigilant' orders ;
  • stop the unit if a unit or a city is found on the way, in the middle of the patch. Then, it will requires another order type (so it is not possible to implement in stable branch) like 'ORDER_ACTION' for the last order to determine if attack was scheduled or not.
pepeto <pepeto>
Project MemberIn charge of this item.
Wed 13 Mar 2013 11:47:09 PM UTC, original submission:

If I set any unit to Go-To to a fogged tile, in which I can't see any enemy unit, I don't want it to attack that enemy unit when it approaches it, for only then it becomes revealed that an enemy unit sits on that tile.
My unit should stop before attacking and let me choose what to do.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 15 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 07 Sep 2014 07:55:21 AM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 05 Sep 2014 08:09:13 AM UTCpepetoAttached File-=>Added S2_5_last_order_move_is_safe2.patch, #22039
      Attached File-=>Added S2_4_last_order_move_is_safe2.patch, #22040
    Wed 03 Sep 2014 03:46:57 PM UTCpepetoAttached File-=>Added trunk_client_goto_non_attack_fogged2.patch, #22011
      Attached File-=>Added S2_4_last_order_move_is_safe.patch, #22012
      Attached File-=>Added S2_5_last_order_move_is_safe.patch, #22013
      StatusIn Progress=>Ready For Test
      Planned Release2.6.0=>2.4.4, 2.5.0, 2.6.0
    Tue 02 Sep 2014 01:13:39 PM UTCpepetoStatusReady For Test=>In Progress
    Tue 02 Sep 2014 08:37:51 AM UTCpepetoAttached File-=>Added trunk_client_goto_non_attack_fogged.patch, #21997
      Categoryclient=>general
      StatusNone=>Ready For Test
    Sat 19 Jul 2014 07:29:26 AM UTCpepetoPlanned Release=>2.6.0
    Sun 06 Jul 2014 08:01:20 AM UTCpepetoAssigned toNone=>pepeto
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup