bugFreeciv - Bugs: bug #20621, Scorelog continuing failure

 
 
Show feedback again

bug #20621: Scorelog continuing failure

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri 15 Mar 2013 12:10:18 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.5, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 28 Mar 2013 09:37:06 PM UTC, SVN revision 22620:

Fixed assert failure if one tries to enable scorelog when it's already
enabled.

See bug #20621

(Browse SVN revision 22620)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 28 Mar 2013 09:37:00 PM UTC, SVN revision 22619:

Fixed assert failure if one tries to enable scorelog when it's already
enabled.

See bug #20621

(Browse SVN revision 22619)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 28 Mar 2013 09:36:53 PM UTC, SVN revision 22618:

Fixed assert failure if one tries to enable scorelog when it's already
enabled.

See bug #20621

(Browse SVN revision 22618)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 25 Mar 2013 10:41:33 PM UTC, comment #2:

Attached fix replaces asserting against double initialization with simple if -test against it.

(file #17542)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 25 Mar 2013 10:35:52 PM UTC, comment #1:

It was probably same problem as one to reproduce with:

1) set scorelog enabled
2) set scorelog enabled

(2) asserts when setting action callback gets called to initialize scorelog already initialized in (1).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 15 Mar 2013 12:10:18 PM UTC, original submission:

Loading saved game after server reboot, scorelog left as it was saving time (i.e, game should continue using it), server scorelog initialization fails some comparison against (or for) NULL assert (saw it only briefly).

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17542:  DoupleScorelogEnable.patch added by cazfi (494B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 28 Mar 2013 09:37:31 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 25 Mar 2013 10:41:33 PM UTCcazfiAttached File-=>Added DoupleScorelogEnable.patch, #17542
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.3.5, 2.4.0, 2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup