bugFreeciv - Bugs: bug #20641, punit->activity_count...

 
 
Show feedback again

bug #20641: punit->activity_count incremented needlessly for sentried units

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 23 Mar 2013 10:20:34 PM UTC  
 
Category: NoneSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: 2.3.4,2.4.0-beta1Operating System: Any
Planned Release: 2.3.5,2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 26 Mar 2013 02:00:53 AM UTC, SVN revision 22604:

Don't increment activity_count without bound while sentrying.
Zero huge activity_counts from old savefiles.

Report and part of patch by pepeto@gna.

See gna bug #20641.

(Browse SVN revision 22604)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 26 Mar 2013 02:00:15 AM UTC, SVN revision 22602:

Don't increment activity_count without bound while sentrying.
Zero huge activity_counts from old savefiles.

Report and part of patch by pepeto@gna.

See gna bug #20641.

(Browse SVN revision 22602)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 26 Mar 2013 01:51:28 AM UTC, SVN revision 22600:

Don't increment activity_count without bound while sentrying.
Zero huge activity_counts from old savefiles.

Report and part of patch by pepeto@gna.

See gna bug #20641.

(Browse SVN revision 22600)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 24 Mar 2013 12:48:26 AM UTC, comment #1:

In addition to pepeto's patch (file #17263), this one zeroes activity_count in savefiles for ACTIVITY_SENTRY.

(file #17526, file #17527)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 23 Mar 2013 10:20:34 PM UTC, original submission:

Split out from bug #20495:

Since r5333, activity_count has been incremented for units doing ACTIVITY_SENTRY, even though it's not used and shouldn't be. This leads to really huge activity_counts.

On trunk, patch #3688 combined with the limited range of the activity_count field on the network makes this really obvious. However, it's not actually causing a bug, as the client only uses activity_count for certain activities, not including ACTIVITY_SENTRY.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17526:  trunk-update-unit-activity-sentry-bis.patch added by jtn (3kB - text/x-diff - trunk/S2_4/S2_3 r22587)
file #17527:  S2_4-S2_3-update-unit-activity-sentry-bis.patch added by jtn (3kB - text/x-diff - trunk/S2_4/S2_3 r22587)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 02:01:39 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 24 Mar 2013 12:48:26 AM UTCjtnAttached File-=>Added trunk-update-unit-activity-sentry-bis.patch, #17526
      Attached File-=>Added S2_4-S2_3-update-unit-activity-sentry-bis.patch, #17527
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup