bugFreeciv - Bugs: bug #20678, Unit pointer used after it might...

 
 
Show feedback again

bug #20678: Unit pointer used after it might died in unit_move_consequences()

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri Mar 29 09:42:14 2013  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed Apr 10 21:18:40 2013, SVN revision 22711:

Do not use unit pointer without makign sure unit still lives after
unit_move_consequences()

See bug #20678

(Browse SVN revision 22711)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Apr 10 21:18:34 2013, SVN revision 22710:

Do not use unit pointer without makign sure unit still lives after
unit_move_consequences()

See bug #20678

(Browse SVN revision 22710)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Apr 8 06:20:24 2013, comment #1:

- Rewritten against current svn head

(file #17711)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Mar 29 09:42:14 2013, original submission:

Unit pointer is being used after unit_move_consequences() call where it can, at least in theory, die. Death would require some unusual lua scripting. This is reggresion since 2.3.

Fix attached

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17711:  MoveDeath-2.patch added by cazfi (7kB - text/x-diff)
file #17588:  MoveDeath.patch added by cazfi (9kB - text/x-diff)
file #17589:  MoveDeath-S2_4.patch added by cazfi (9kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Apr 10 21:18:58 2013cazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon Apr 8 06:20:24 2013cazfiAttached File-=>Added MoveDeath-2.patch, #17711
      StatusIn Progress=>Ready For Test
    Sun Mar 31 18:54:18 2013cazfiStatusReady For Test=>In Progress
    Fri Mar 29 09:47:11 2013cazfiDependencies-=>bugs #20679 is dependent
    Fri Mar 29 09:42:14 2013cazfiAttached File-=>Added MoveDeath.patch, #17588
      Attached File-=>Added MoveDeath-S2_4.patch, #17589
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup