bugFreeciv - Bugs: bug #20689, Maxplayers setting gets set to...

 
 
Show feedback again

bug #20689: Maxplayers setting gets set to number of game start players when loading savegame

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 31 Mar 2013 12:30:10 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.5, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 07 Apr 2013 07:10:52 AM UTC, SVN revision 22683:

Do not set value of maxplayers setting to number of starting positions
(=players at the time game started) when loading saved game that is no longer
in pregame state.

See bug #20689

(Browse SVN revision 22683)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 07 Apr 2013 07:10:46 AM UTC, SVN revision 22682:

Do not set value of maxplayers setting to number of starting positions
(=players at the time game started) when loading saved game that is no longer
in pregame state.

See bug #20689

(Browse SVN revision 22682)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 07 Apr 2013 07:10:30 AM UTC, SVN revision 22681:

Do not set value of maxplayers setting to number of starting positions
(=players at the time game started) when loading saved game that is no longer
in pregame state.

See bug #20689

(Browse SVN revision 22681)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 02 Apr 2013 08:21:23 PM UTC, comment #1:

This feels a bit like kludge on top of kludge. Shouldn't scenario file be giving correct maxplayers setting in the first place? Current patches are probably best thing we can get to stable branches (don't want to break scenarios that currently work on them), but in the future it should at least warn if maxplayers setting in scenario does not make sense.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 31 Mar 2013 12:30:10 AM UTC, original submission:

Split from bug #19474:

When loading savegame of running game, maxplayers setting gets set to number of players in game.

This is because there's code meant to limit max_players in scenarios to number of starting positions - there cannot be more players than starting positions. That same code gets wrongly applied when one loads already started game with generated starting positions. Number of generated starting positions is one for each player who was present when game started -> maxplayers gets set to number of game start players.

Attached fix makes maxplayer to be set to number of starting positions in pregame only.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 07 Apr 2013 07:11:11 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 31 Mar 2013 12:40:53 AM UTCcazfiDependencies-=>bugs #19474 is dependent
    Sun 31 Mar 2013 12:30:10 AM UTCcazfiAttached File-=>Added RunningGameStartposCount.patch, #17618
      Attached File-=>Added RunningGameStartposCount-S2_4.patch, #17619
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup