bugFreeciv - Bugs: bug #20690, maxplayers setting does not...

 
 
Show feedback again

bug #20690: maxplayers setting does not prevent midgame player /create

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 31 Mar 2013 12:39:37 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 18 Apr 2013 07:52:46 PM UTC, SVN revision 22728:

Increase maxplayers value when midgame /create command makes old value
to be exceeded.

See bug #20690

(Browse SVN revision 22728)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 18 Apr 2013 07:52:41 PM UTC, SVN revision 22727:

Increase maxplayers value when midgame /create command makes old value
to be exceeded.

See bug #20690

(Browse SVN revision 22727)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 16 Apr 2013 10:14:04 AM UTC, comment #3:

- Removed accidental change to player.h

(file #17753)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 08 Apr 2013 06:53:56 AM UTC, comment #2:

I think we must postpone restricting newcomer creation, and civil war player creation, by maxplayers setting. Newcomer creation part is anyway unimportant in that player requests it explicitly, and thus current behavior can be considered just user-friendlier way to do two player actions "increase maxplayers" + "create player". Civil war I consider a bit more a problem, as that can increase number of players over maxplayers even when that's not desired (most important use-case for me would be, as a public server operator, to limit number of players with ruleset-locked maxplayer setting)

Anyway, attached patch fixes the newcomer creation to work in respect to maxplayers similar to civil war - increase maxplayers if it's reached, so that player count does not end up bigger than maxplayers limit.

(file #17712)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 03 Apr 2013 10:28:32 PM UTC, comment #1:

Given that "maxplayers" value cannot be currently changed in running game, and that bug #20689 has caused it to be set to number of players in game start (= if nobody has died it's equal to current players) in old savegames already gone over one save/load cycle before, using the setting against midgame player creation would block cases where it should be allowed.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 31 Mar 2013 12:39:37 AM UTC, original submission:

One can /create players to running game without maxplayers setting any way restricting it. Fix attached.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17712:  MaxplayersNewcomer.patch added by cazfi (2kB - text/x-diff)
file #17620:  MidgameMaxplayers.patch added by cazfi (670B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 18 Apr 2013 07:52:58 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 16 Apr 2013 10:14:04 AM UTCcazfiAttached File-=>Added MaxplayersNewcomer-2.patch, #17753
    Mon 08 Apr 2013 06:53:56 AM UTCcazfiAttached File-=>Added MaxplayersNewcomer.patch, #17712
      StatusIn Progress=>Ready For Test
    Wed 03 Apr 2013 10:28:32 PM UTCcazfiStatusReady For Test=>In Progress
    Sun 31 Mar 2013 12:41:06 AM UTCcazfiDependencies-=>bugs #19474 is dependent
    Sun 31 Mar 2013 12:39:37 AM UTCcazfiAttached File-=>Added MidgameMaxplayers.patch, #17620
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup