bugFreeciv - Bugs: bug #20699, Bugs in undisbandable unit drowning

 
 
Show feedback again

bug #20699: Bugs in undisbandable unit drowning

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 01 Apr 2013 01:20:51 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 04 Apr 2013 07:45:02 PM UTC, SVN revision 22669:

Fixed handling of undisbandable units being saved from drowning by
teleporting them to safe city. They could be drown still after they
had been teleported, and instead some other unit left alive swimming in
the ocean.

See bug #20699

(Browse SVN revision 22669)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 04 Apr 2013 07:44:57 PM UTC, SVN revision 22668:

Fixed handling of undisbandable units being saved from drowning by
teleporting them to safe city. They could be drown still after they
had been teleported, and instead some other unit left alive swimming in
the ocean.

See bug #20699

(Browse SVN revision 22668)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 02 Apr 2013 07:36:43 PM UTC, comment #1:

jtn: This particular bug was my mistake in bug #20442, reggression since 2.4.0-beta1. No need to mention in beta2 NEWS (as change relative to beta1) assuming that fix gets committed before it.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 01 Apr 2013 01:20:51 PM UTC, original submission:

While hunting another drowning bug, noticed a problem in undisbandable unit saving block.

Even after undisbandable unit has been saved by teleporting it, it gets added to "remain" list of units to handle later. This can have many kind of ill effects since it also means that "drowning" counter is inconsistent with contents of "remain"

Fix attached.

Also: pcity was declared in outer block which didn't need it. Set its visibility to inner block only.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17646:  UndisbandDrowning.patch added by cazfi (2kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 07 Apr 2013 10:10:36 AM UTCjtnDependencies-=>bugs #20722 is dependent
    Thu 04 Apr 2013 07:45:33 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 01 Apr 2013 01:20:52 PM UTCcazfiAttached File-=>Added UndisbandDrowning-S2_4.patch, #17647
    Mon 01 Apr 2013 01:20:51 PM UTCcazfiAttached File-=>Added UndisbandDrowning.patch, #17646
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup