bugBattle for Wesnoth - Bugs: bug #20704, [effect] apply_to=new_animation...

 
 
Show feedback again

bug #20704: [effect] apply_to=new_animation crashes the game later

Submitted by:  B. Lipka <lipk>
Submitted on:  Tue 02 Apr 2013 07:07:32 PM UTC  
 
Category: BugSeverity: 4 - Important
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: J Tyne <jamit>Open/Closed: Closed
Release: 1.11.2+devOperating System: Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 23 Jun 2013 03:50:02 AM UTC, comment #4:

Fixed in 8733b8f1444cdf8aa5590e9992fbf66b8efa6cea.

J Tyne <jamit>
Project MemberIn charge of this item.
Wed 24 Apr 2013 03:28:25 AM UTC, comment #3:

Fixing this at both ends would be cool, only... well, I suppose that is something to mention on the patch's page.

J Tyne <jamit>
Project MemberIn charge of this item.
Mon 22 Apr 2013 06:41:11 AM UTC, comment #2:

thunderstruck has also been working on this, (see https://gna.org/patch/?3862), could you please discuss this with him?

B. Lipka <lipk>
Project Member
Mon 22 Apr 2013 01:56:04 AM UTC, comment #1:

Hmm... the crash occurs because units are being created outside the context of a game, and the unit class often assumes or asserts that it is in the context of a game (i.e. that the global resources:: point to things).

Not sure which would be the more correct fix -- change the unit class or change the code that creates units outside games. However, it looks like the latter would be a net efficiency gain, so that is probably worth committing once it's had some testing (I already have the changes locally). If that would also be considered a fix to this bug (not just a band-aid), go ahead and assign it to me.

J Tyne <jamit>
Project MemberIn charge of this item.
Tue 02 Apr 2013 07:07:32 PM UTC, original submission:

If there's an item with an [effect] that adds a new animation, the game will crash if the unit that picked up the item still exists at the end of the scenario.

This issue may render mainline content unplayable, so I'm marking it as a blocker.

Attached a test case.

B. Lipka <lipk>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17659:  crashtest.zip added by lipk (2kB - application/zip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by jamit (Posted a comment)
  • -unavailable- added by lipk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 27 Jun 2013 10:00:54 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 23 Jun 2013 03:50:01 AM UTCjamitStatusIn Progress=>Fixed
    Sun 12 May 2013 04:40:09 PM UTCivanovicSeverity5 - Blocker=>4 - Important
    Sat 11 May 2013 01:12:41 AM UTCjamitStatusNone=>In Progress
      Assigned toNone=>jamit
    Tue 02 Apr 2013 07:07:32 PM UTClipkAttached File-=>Added crashtest.zip, #17659
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup