bugFreeciv - Bugs: bug #20705, Transported unit in tile going...

 
 
Show feedback again

bug #20705: Transported unit in tile going fogged

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 03 Apr 2013 08:28:32 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Ready For Test
Assigned to: pepeto <pepeto>Open/Closed: Open
Release: Operating System: Any
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 22 Oct 2014 02:18:19 PM UTC, comment #3:

Forgot to mention there will be one remaining bug: after B takes C city, A see the city unoccupied (fogged tile).

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 22 Oct 2014 01:21:14 PM UTC, comment #2:

> Noticed that in all branches, A was not able to click B's
> transport to see units inside.

Raised as bug #22851.

> Client A gets the following error messages:
> 1: in unit_transport_unload() [unit.c::2105]: assertion
> 'same_pos(unit_tile(pcargo), unit_tile(ptrans))' failed.

Raised as bug #22852.

> 1: Server wants us to remove unit id 119, but we don't know about this unit!

Raised as bug bug #22853 for two of them. Fixing the two other here.

> Client C gets the following error messages (unexpected in
> original summary I think):
> 1: 0x1d606c0 119 Galleon at (32,25) B
> 1: in handle_tile_info() [packhand.c::2730]: assertion '0 ==
> unit_list_size(ptile->units)' failed.

Fix attached: transfer_city() now hide/reveal units for all players (removed the saw_entering) which was only working for one unit and which was also not enabled in the case of city transferring by diplomatic treaty.

Not targeting for 2.4.4, because:

  • there is no supplied ruleset able to reproduce this bug;
  • this would only throw safe assertion, it is still possible to play with them;
  • I am quite scared to break something else;
  • it would require more work than for S2_5 and trunk.

(file #22707, file #22708)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 22 Oct 2014 08:56:39 AM UTC, comment #1:

Attaching savegame for testing matching comment #0 description.

Noticed that in all branches, A was not able to click B's transport to see units inside.

Client A gets the following error messages:
(+ TRUNK only)

Client C gets the following error messages (unexpected in original summary I think):

Client B and server have no error messages.

(file #22699)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 03 Apr 2013 08:28:32 PM UTC, original submission:

I think there would be still one combination corner case even when bug #20663 (when transport moves, cargo is temporarily in old tile when it's already required in new tile) and bug #19989 (info about unit movement not yet sent to client when movement causes old tile to become fogged) are fixed ot the extend of their current proposed patches. It's still possible that cargo has not yet moved when tile gets fogged.

We may get away this by the fact that also server thinks that cargo has not yet moved - so server and client are not out-of-sync about what units exist in tile getting fogged.

I have not tested, but I think it's possible to create such an situation:
1) Client A is allied to player B (sees inside transports)
2) A has shared vision from player C
3) B & C are at war
4) Ruleset has transport capable of occupying cities
5) A sees some B's transport only thanks to shared vision from C (that's a bit odd situation itself - C itself does not see inside B's transport, but still gives that information to A?). More precisely: B's transport is seen by C's empty city next to said city
6) B's transport moves to occupy C's city. C and A lose vision of the area.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22699:  bug20705.sav.bz2 added by pepeto (12kB - application/x-bzip)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 22 Oct 2014 01:21:14 PM UTCpepetoAttached File-=>Added trunk_transfer_city_reveal_hide_units.patch, #22707
      Attached File-=>Added S2_5_transfer_city_reveal_hide_units.patch, #22708
      StatusIn Progress=>Ready For Test
      Planned Release=>2.5.0, 2.6.0
    Wed 22 Oct 2014 08:56:39 AM UTCpepetoAttached File-=>Added bug20705.sav.bz2, #22699
      CategoryNone=>general
      StatusNone=>In Progress
      Assigned toNone=>pepeto
      Operating SystemNone=>Any
    Sun 07 Apr 2013 10:08:10 AM UTCjtnDependencies-=>bugs #20722 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup