bugFreeciv - Bugs: bug #20713, Tilespec river types list not...

 
 
Show feedback again

bug #20713: Tilespec river types list not cleared when ruleset changes

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 04 Apr 2013 09:56:23 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 29 May 2013 11:33:57 PM UTC, SVN revision 22908:

Reset list of road types that should be drawn as rivers when client
receives new ruleset.

See bug #20713

(Browse SVN revision 22908)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 29 May 2013 11:33:46 PM UTC, SVN revision 22907:

Reset list of road types that should be drawn as rivers when client
receives new ruleset.

See bug #20713

(Browse SVN revision 22907)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 26 May 2013 09:21:59 PM UTC, comment #1:

Fix

(file #18014)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 04 Apr 2013 09:56:23 PM UTC, original submission:

tilespec.c maintains list of road types that are drawn with river style gfx. The list is created a new when tileset changes, but changing rulesets just adds new river types to it.

To reproduce:
1) Launch client to new game pregame using Amplio2. Classic ruleset gets automatically loaded, with road id 2 as "River".
2) Change ruleset to Alien, which has "Maglev" in 2.
3) Start game
4) Place some Maglevs in the editor. There's river graphics drawn in addition to road graphics.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18014:  TilesetRulesetReset.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 29 May 2013 11:34:10 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 26 May 2013 09:21:59 PM UTCcazfiAttached File-=>Added TilesetRulesetReset.patch, #18014
      StatusNone=>Ready For Test
      Planned Release2.5.0=>2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup