bugBattle for Wesnoth - Bugs: bug #20716, "Descriptions should no...

 
 
Show feedback again

bug #20716: "Descriptions should no longer include the name as the first line." is too vague

Submitted by:  Anonymissimus <anonymissimus>
Submitted on:  Fri 05 Apr 2013 05:00:53 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: J Tyne <jamit>Open/Closed: Closed
Release: trunkOperating System: all

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 24 Jun 2013 12:17:45 AM UTC, comment #6:

Fixed in 6692510e23c02c2402418875f0b21b515e2e84dc. Or at least improved. Let me know if it's not good enough.

J Tyne <jamit>
Project MemberIn charge of this item.
Mon 15 Apr 2013 01:57:25 AM UTC, comment #5:

Well, the message gets emitted when the help system encounters such a description. Sometimes the help system decides it needs to build all unit types, not necessarily just the one that was clicked. (Why? Not sure. Someone did it that way.) I had made a few tweaks to reduce how often this occurs, but it still happens.

(The message comes from the help system because that is an easy way to ensure the message is sent only once per description per scenario(? game? something?), rather than potentially multiple times per turn.)

J Tyne <jamit>
Project MemberIn charge of this item.
Tue 09 Apr 2013 07:46:07 PM UTC, comment #4:

Yes, I found another ability which I had overlooked that way. Hopefully they're gone now.
Still unclear why it did look for the string upon clicking some different unit.

Anonymissimus <anonymissimus>
Project Member
Mon 08 Apr 2013 11:40:10 PM UTC, comment #3:

If you want to make a change to help you track down the source of the messages, you can add the full description to the message (not a good solution, but quick and easy to describe). That message is given in help.cpp, line 1175 (in my local version; not sure if the file has been changed recently). The variable named revision holds the full description, so you could just stream that into the error message as a stopgap measure.

This will be an easy thing to fix, but this past weekend I wasn't sure where commits were supposed to go, and I didn't want to spend time creating a SourceForge account if it was going to be useless almost right away.

J Tyne <jamit>
Project MemberIn charge of this item.
Mon 08 Apr 2013 04:58:44 PM UTC, comment #2:

I think I eliminated all abilities/weapon specials with this case, but the message still seems to come at random when clicking on units. It did happen even in a case when all of the units on the map with an ability or special were freshly created as opposed to carried over from a save as a recall list unit or variable. Since I started the playthrough with the old descriptions, I would expect these units to have old ones.

Anonymissimus <anonymissimus>
Project Member
Fri 05 Apr 2013 05:37:59 PM UTC, comment #1:

The error message should include that exact name it complains about.

Anonymissimus <anonymissimus>
Project Member
Fri 05 Apr 2013 05:00:53 PM UTC, original submission:

This message seemed to pop up at random. I had to browse the code
and the history to find out what's up with it. It is still not clear to me by what sort of user action(s) it is triggered.
So, it should be reworded so that an addon author realizes that he must have some weapon special or ability description where this is the case.
(A wmllint rule would also be nice.)

Anonymissimus <anonymissimus>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by jamit (Posted a comment)
  • -unavailable- added by anonymissimus (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 27 Jun 2013 10:02:31 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Mon 24 Jun 2013 12:17:45 AM UTCjamitStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup