bugFreeciv - Bugs: bug #20720, Transport allied cargo check...

 
 
Show feedback again

bug #20720: Transport allied cargo check doesn't recurse

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 06 Apr 2013 10:08:12 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: 2.4.0-beta1Operating System: Any
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 08 Apr 2013 11:37:34 PM UTC, SVN revision 22699:

Prevent deeply nested allied units from being transported onto tile with
non-allies of theirs.

See gna bug #20720.

(Browse SVN revision 22699)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 08 Apr 2013 11:32:22 PM UTC, SVN revision 22697:

Prevent deeply nested allied units from being transported onto tile with
non-allies of theirs.

See gna bug #20720.

(Browse SVN revision 22697)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 06 Apr 2013 10:24:20 PM UTC, comment #1:

Patch fixes this in a slightly ad-hoc way.
Perhaps if we get many more of these we should add tools to iterate over transported units, and/or "is unit X transitively transported by Y".

(file #17691)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 06 Apr 2013 10:08:12 PM UTC, original submission:

Noticed in passing: in unit_move_handling() there's a check when moving transporters that we're not moving allied cargo from A onto a tile containing units/city from ally B where A and B aren't allied. However, it only checks for immediate cargo, not nested cargo.

Tested with attached (trunk) savegame. Illegal move is allowed, and then on turn done, we get some assertion failures from the server.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17691:  trunk-S2_4-allied-cargo-move.patch added by jtn (1kB - text/x-diff - trunk/S2_4 r22677)
file #17690:  alliance-units.sav.bz2 added by jtn (14kB - application/x-bzip - trunk savegame for testing allied cargo cases)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 08 Apr 2013 11:38:43 PM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 07 Apr 2013 10:11:32 AM UTCjtnDependencies-=>bugs #20722 is dependent
    Sat 06 Apr 2013 10:24:20 PM UTCjtnAttached File-=>Added trunk-S2_4-allied-cargo-move.patch, #17691
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
      Release=>2.4.0-beta1
    Sat 06 Apr 2013 10:08:12 PM UTCjtnAttached File-=>Added alliance-units.sav.bz2, #17690
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup