bugFreeciv - Bugs: bug #20721, Recursive logging

 
 
Show feedback again

bug #20721: Recursive logging

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 07 Apr 2013 06:36:51 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 30 Apr 2013 07:01:35 PM UTC, SVN revision 22796:

Do not call freelog recursively from convert_string()

See bug #20721

(Browse SVN revision 22796)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 30 Apr 2013 07:01:30 PM UTC, SVN revision 22795:

Do not call freelog recursively from convert_string()

See bug #20721

(Browse SVN revision 22795)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 28 Apr 2013 09:24:23 AM UTC, comment #1:

Attached patch replaces logging functions in convert_string() with fprintf().
I think S2_3 is safe from this problem as the logging mutex is not used there.

(file #17840)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 07 Apr 2013 06:36:51 AM UTC, original submission:

Not sure what's the bug(s) here, but the whole does not work.

Noticed S2_4 autogame that hadn't proceeded single turn in a day. Attaching debugger revealed that it was trying to allocate logging mutex in log_real(). Without threaded ai type in use, deadlock between two threads seemed unlikely (that's the only mutex ever used!) And indeed backtrace shows that logging gets called recursively, so it was the upper level call that had already locked the mutex.

Latter logging is about invalid conversion in convert_string()

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17840:  RecursiveLog.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 30 Apr 2013 07:01:47 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 28 Apr 2013 09:24:23 AM UTCcazfiAttached File-=>Added RecursiveLog.patch, #17840
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.4.0, 2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup