bugFreeciv - Bugs: bug #20726, Units in allied transport already...

 
 
Show feedback again

bug #20726: Units in allied transport already when treaty made not shown

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 07 Apr 2013 09:48:25 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.4.4, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 24 Oct 2014 04:38:18 PM UTC, SVN revision 26853:

Link transporter units with their cargo for foreigner players. It was broken
when the transporter info was received after the cargo info.

Originally reported by Marko Lindqvist in bug #20726

See gna bug #22851

(Browse SVN revision 26853)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 24 Oct 2014 04:38:14 PM UTC, SVN revision 26852:

Link transporter units with their cargo for foreigner players. It was broken
when the transporter info was received after the cargo info.

Originally reported by Marko Lindqvist in bug #20726

See gna bug #22851

(Browse SVN revision 26852)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 24 Oct 2014 04:38:09 PM UTC, SVN revision 26851:

Link transporter units with their cargo for foreigner players. It was broken
when the transporter info was received after the cargo info.

Originally reported by Marko Lindqvist in bug #20726

See gna bug #22851

(Browse SVN revision 26851)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 24 Oct 2014 04:33:21 PM UTC, SVN revision 26850:

Give the visibility of units of a player when contracting an alliance with him
(e.g. transported units or units in cities).

Reported by Marko Lindqvist

See gna bug #20726

(Browse SVN revision 26850)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 24 Oct 2014 04:33:17 PM UTC, SVN revision 26849:

Give the visibility of units of a player when contracting an alliance with him
(e.g. transported units or units in cities).

Reported by Marko Lindqvist

See gna bug #20726

(Browse SVN revision 26849)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 24 Oct 2014 04:33:12 PM UTC, SVN revision 26848:

Give the visibility of units of a player when contracting an alliance with him
(e.g. transported units or units in cities).

Reported by Marko Lindqvist

See gna bug #20726

(Browse SVN revision 26848)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 22 Oct 2014 12:58:43 PM UTC, comment #4:

> allied units are not revealed when players agree on alliance


Fix attached.

> depending on the order of the unit are sent to the client, it
> is sometimes impossible to see what units are in a transporter
> in the unit selection dialog (also mentioned bug #20705).


Raised as bug #22851.

(file #22702, file #22703)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 22 Oct 2014 10:01:55 AM UTC, comment #3:

I clearly see 2 different issues here:

  • allied units are not revealed when players agree on alliance;
  • depending on the order of the unit are sent to the client, it is sometimes impossible to see what units are in a transporter in the unit selection dialog (also mentioned bug #20705).
pepeto <pepeto>
Project MemberIn charge of this item.
Mon 12 May 2014 01:38:01 PM UTC, comment #2:

I fail to reproduce. Is it still reproducible for you?

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 29 Apr 2013 12:15:31 AM UTC, comment #1:

I tested this with S2_3 too. It didn't give failing asserts, but the behavior was the same.
So at least this is not a reggression since 2.3, and thus not necessarily 2.4.0 blocker.

Marko Lindqvist <cazfi>
Project Administrator
Sun 07 Apr 2013 09:48:25 PM UTC, original submission:

I had loaded player A transport that B saw when the players agreed on alliance. After they had allied, B was still unable to access cargo of the transport via unit selection dialog, moving it out of B's sight split out number (probably 1 / cargo unit) transported(punit) != NULL assert failures. Curiously the problem was not fixed when transport moved back to B's sight (though units should be created anew to B's client at that point) but moving one new A's unit from the shore to the transport fixed it - B was able to see all units inside transport.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 24 Oct 2014 04:33:31 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 22 Oct 2014 12:58:43 PM UTCpepetoAttached File-=>Added trunk_S2_5_give_allied_visibility.patch, #22702
      Attached File-=>Added S2_4_give_allied_visibility.patch, #22703
      CategoryNone=>general
      StatusIn Progress=>Ready For Test
      Operating SystemNone=>Any
      Planned Release=>2.4.4, 2.5.0, 2.6.0
    Wed 22 Oct 2014 10:01:55 AM UTCpepetoStatusNone=>In Progress
      Assigned toNone=>pepeto
    Mon 08 Apr 2013 12:20:40 AM UTCjtnDependencies-=>bugs #20722 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup