bugFreeciv - Bugs: bug #20727, Fogging problems when allied...

 
 
Show feedback again

bug #20727: Fogging problems when allied transport moves out of sight.

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 07 Apr 2013 10:06:34 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 May 2013 02:06:03 PM UTC, SVN revision 22805:

Move all the units in recursive transports before telling client that
they go out of sight. This fixes client side problem that units were
being unloaded for removal while the transport and cargo were not in the
same tile.

See bug #20727

(Browse SVN revision 22805)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 01 May 2013 02:05:57 PM UTC, SVN revision 22804:

Move all the units in recursive transports before telling client that
they go out of sight. This fixes client side problem that units were
being unloaded for removal while the transport and cargo were not in the
same tile.

See bug #20727

(Browse SVN revision 22804)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 29 Apr 2013 08:33:37 AM UTC, comment #1:

My current work on this ticket. All the transported (recursively) units are moved to destination tile before any of them is removed from client end.

This is not really tested as I then hit bug #20774.

(file #17852)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 07 Apr 2013 10:06:34 PM UTC, original submission:

From bug #20663:
"For the client side I also wonder what happens when allied transport (of which you see units inside) moves out of sight. Does transport get removed from the client when cargo is still in another tile?"

I tested this and got bunch of assert failures. First ones were, as expected:
assertion 'same_pos(unit_tile(pcargo), unit_tile(ptrans))' failed.
then followed by one:
assertion 'unit_list_size(punit->transporting) == 0' failed.
and finally a couple of:
assertion '!unit_transported(punit)' failed.

First ones are when fogging of transport tries to unload cargo that's still in another (visible) tile. After the unloading has failed, fails the second assert that makes sure that unloading has succeeded. Finally cargo should be removed but has still loaded status after failed unloading.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 May 2013 02:06:15 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 29 Apr 2013 08:33:37 AM UTCcazfiAttached File-=>Added CargoOutOfSightSameTile.patch, #17852
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.4.0, 2.5.0, 2.6.0
    Mon 08 Apr 2013 12:19:08 AM UTCjtnDependencies-=>bugs #20722 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup