bugFreeciv - Bugs: bug #20758, Buoys getting vision twice

 
 
Show feedback again

bug #20758: Buoys getting vision twice

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon Apr 22 14:15:54 2013  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: trunk r27025Operating System: Any
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon Jan 26 10:36:25 2015, SVN revision 27852:

Fix a typo that was causing the buoys to give vision forever (uneless the user
saves and reloads the game) even if the base was removed.

See gna bug #20758

(Browse SVN revision 27852)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Jan 26 10:36:23 2015, SVN revision 27851:

Fix a typo that was causing the buoys to give vision forever (uneless the user
saves and reloads the game) even if the base was removed.

See gna bug #20758

(Browse SVN revision 27851)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat Jan 24 10:18:26 2015, comment #5:

I have found the cause of the bug. It is clearly not the same as originally reported (probably invalid, see comment #1). It was due to a typo in patch #3873. Fix attached.

(file #23599)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue Nov 11 09:48:36 2014, comment #4:

I have reproduced on TRUNK HEAD. Only occurs when building the buoys. If the game is reloaded, the "seen" count of the tiles is right.

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Oct 22 08:21:24 2014, comment #3:

As mentioned at comment #2, this ticket seems invalid. I again tried to reproduce with the information given at comment #1, without success.

pepeto <pepeto>
Project MemberIn charge of this item.
Sat Jul 19 14:49:27 2014, comment #2:

I fail to reproduce.

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Apr 22 15:09:18 2013, comment #1:

This report is probably invalid. What I thought to be "A & B" is in fact "if (x) { A } else { B }"

Marko Lindqvist <cazfi>
Project Administrator
Mon Apr 22 14:15:54 2013, original submission:

I have not yet tried to reproduce, but I've got indications that vision bases get vision assigned twice in S2_5 (current TRUNK, but 2.6 related base ownership rework will fix this in TRUNK after S2_5 has been branched). As in earlier branches, vision base get vision explicitly assigned upon its creation. But in S2_5 base creation is reworked so that map_claim_base() handles all the effects of the base ownership changes - this includes giving vision to player who gets vision base.

Duoble vision could manifest itself when base gets removed - vision gets removed only once, leaving player with positive vision counter of the tiles (s)he should no longer see.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23599:  create_base_old_claim.patch added by pepeto (501B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 16 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Jan 26 10:36:38 2015pepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat Jan 24 10:18:26 2015pepetoAttached File-=>Added create_base_old_claim.patch, #23599
      StatusIn Progress=>Ready For Test
      Operating SystemNone=>Any
      Planned Release2.6.0=>2.6.0, 3.0.0
    Tue Nov 11 09:48:36 2014pepetoCategoryNone=>general
      StatusInvalid=>In Progress
      Assigned toNone=>pepeto
      Open/ClosedClosed=>Open
      Release=>trunk r27025
      Planned Release=>2.6.0
    Wed Oct 22 08:21:24 2014pepetoStatusNeed Info=>Invalid
      Open/ClosedOpen=>Closed
      Planned Release2.5.0=>
    Sat Jul 19 14:49:27 2014pepetoStatusNone=>Need Info
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup