bugFreeciv - Bugs: bug #20778, Memory overwrite errors

 
 
Show feedback again

bug #20778: Memory overwrite errors

Submitted by:  None
Submitted on:  Wed 01 May 2013 09:37:53 PM UTC  
 
Category: generalSeverity: 4 - Important
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Originator Email: -unavailable-
Open/Closed: ClosedRelease: trunk
Operating System: GNU/LinuxPlanned Release: 2.3.5, 2.4.0, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 30 May 2013 06:45:47 PM UTC, SVN revision 22925:

Prevent writting one byte earlier empty string for get_infrastructure_text().

Report and patch by Per Mathisen (adapted by me)

See gna bug #20778

(Browse SVN revision 22925)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 30 May 2013 06:45:43 PM UTC, SVN revision 22924:

Prevent writting one byte earlier empty string for get_infrastructure_text().

Report and patch by Per Mathisen

See gna bug #20778

(Browse SVN revision 22924)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 30 May 2013 06:45:38 PM UTC, SVN revision 22923:

Prevent writting one byte earlier empty string for get_infrastructure_text().

Report and patch by Per Mathisen

See gna bug #20778

(Browse SVN revision 22923)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 30 May 2013 06:45:28 PM UTC, SVN revision 22922:

Prevent writting one byte earlier empty string for get_infrastructure_text().

Report and patch by Per Mathisen

See gna bug #20778

(Browse SVN revision 22922)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 30 May 2013 06:38:35 PM UTC, SVN revision 22921:

Allocate correct memory size for threads.

Report and path by Per Mathisen

See gna bug #20778

(Browse SVN revision 22921)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 30 May 2013 06:38:24 PM UTC, SVN revision 22920:

Allocate correct memory size for threads.

Report and path by Per Mathisen

See gna bug #20778

(Browse SVN revision 22920)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 30 May 2013 06:37:53 PM UTC, SVN revision 22919:

Allocate correct memory size for threads.

Report and path by Per Mathisen

See gna bug #20778

(Browse SVN revision 22919)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 24 May 2013 05:07:30 PM UTC, comment #2:

Attached separate patches.

(file #18004, file #18005, file #18006)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 21 May 2013 07:31:25 AM UTC, comment #1:

Both issues are not related in my opinion.

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 01 May 2013 09:37:53 PM UTC, original submission:

One case of memory being overwritten one byte too early (terrain.c, if string is empty), and one case of too small memory allocation (fcthread.c, it is allocated to size of pointer rather than size of content).

Patch to fix issues attached.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18004:  fcthread_init_fix.diff added by pepeto (870B - text/x-diff)
file #17870:  fix-asan.diff added by None (1kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 30 May 2013 06:46:20 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 24 May 2013 05:07:30 PM UTCpepetoAttached File-=>Added fcthread_init_fix.diff, #18004
      Attached File-=>Added trunk_S2_5_S2_3_empty_infrastructure_text.diff, #18005
      Attached File-=>Added S2_4_empty_infrastructure_text.diff, #18006
      Planned Release2.4.0, 2.5.0, 2.6.0=>2.3.5, 2.4.0, 2.5.0, 2.6.0
    Tue 21 May 2013 07:31:25 AM UTCpepetoStatusNone=>Ready For Test
      Assigned toNone=>pepeto
      Planned Release=>2.4.0, 2.5.0, 2.6.0
    Wed 01 May 2013 09:37:53 PM UTCNoneAttached File-=>Added fix-asan.diff, #17870
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup