bugFreeciv - Bugs: bug #20786, Pathfinder (Goto order) for aerial...

 
 
Show feedback again

bug #20786: Pathfinder (Goto order) for aerial units

Submitted by:  None
Submitted on:  Sat 04 May 2013 09:33:45 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 2.4.0-beta2
Operating System: AnyPlanned Release: 2.3.5, 2.4.0, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 11 May 2013 02:49:54 PM UTC, comment #12:

You're right, sorry... Fixed now.

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 11 May 2013 02:49:16 PM UTC, SVN revision 22850:

Remove extra line in path finding code, causing fueled units to stop at all
refuel points of their path.

Reported by Michael Srp

See gna bug #20786

(Browse SVN revision 22850)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 11 May 2013 02:41:56 PM UTC, comment #10:

Fix needs to go on recently-branched S2_5 too?

Jacob Nevins <jtn>
Project Administrator
Sat 11 May 2013 02:40:15 PM UTC, SVN revision 22848:

Remove extra line in path finding code, causing fueled units to stop at all
refuel points of their path.

Reported by Michael Srp

See gna bug #20786

(Browse SVN revision 22848)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 11 May 2013 02:40:14 PM UTC, SVN revision 22847:

Remove extra line in path finding code, causing fueled units to stop at all
refuel points of their path.

Reported by Michael Srp

See gna bug #20786

(Browse SVN revision 22847)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 11 May 2013 02:40:12 PM UTC, SVN revision 22846:

Remove extra line in path finding code, causing fueled units to stop at all
refuel points of their path.

Reported by Michael Srp

See gna bug #20786

(Browse SVN revision 22846)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 09 May 2013 02:44:41 PM UTC, comment #6:

Found the cause: I made an extra line which was overwritting the waited status of every new nodes for patch #2145.

Patch attached.

(file #17940)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 08 May 2013 08:56:37 AM UTC, comment #5:

I see what you mean. Savegame attached.

(file #17926)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 07 May 2013 06:50:36 PM UTC, comment #4:

Yes, I am sure. The most annoying it is when I want my bomber to attack a target and there is unintentionally some city or airbase on the way. I have to navigate it manually. Otherwise it stops there and finishes attack refueled in the next turn. I am professional software tester. The problem is just that the code orders aerial units to stop at every base on it's way regardless the distance to the next one. It should compare the distance of each base on the way of the unit and it's final destination to it's number of movepoints before each turn and order it to stop just at the most distant one within unit's action radius.

Anonymous
Tue 07 May 2013 05:49:26 PM UTC, comment #3:

I have worked on the airplane pathfinding code. I dunno if what you describe is a bug.

Are you sure you are attempting to send a plan where it can end its turn without getting out of fuel?

Else, this is a feature. You can reach out of fuel tiles with keyboard only. Or, the path will go to refuel before reaching the tile.

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 07 May 2013 05:21:30 PM UTC, comment #2:

This bug is so common I thought it wouldn't be necessary. Just try to order any plane or missile to reach any base (or even attack target) within it's action radius when there is another base on it's way. I can sent you a savegame to your email, but can't upload it here due to upload size limit. I use very large maps and the file is too big.

Anonymous
Sun 05 May 2013 04:04:32 PM UTC, comment #1:

Could you attach a savegame this bug could be observed?

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 04 May 2013 09:33:45 PM UTC, original submission:

All aerial units (all planes, all missiles) ordered with Goto order always stop in every base (own or allied cities, airbases, carriers, submarines in case of missiles) for refueling although they have enough movepoints to reach the next one. This causes delays of their arrival. No matter if this base is intentional waypoint or they just randomly travel through it. This affects both 2.4.0 beta versions, default ruleset.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17926:  airplane-test.sav.gz added by pepeto (7kB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 11 May 2013 02:49:54 PM UTCpepetoPlanned Release2.3.5, 2.4.0, 2.5.0=>2.3.5, 2.4.0, 2.5.0, 2.6.0
    Sat 11 May 2013 02:40:30 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 09 May 2013 02:44:41 PM UTCpepetoAttached File-=>Added path_finding_remove_extra_line.diff, #17940
      CategoryNone=>general
      StatusNone=>Ready For Test
      Operating SystemMicrosoft Windows=>Any
      Planned Release=>2.3.5, 2.4.0, 2.5.0
    Wed 08 May 2013 08:56:37 AM UTCpepetoAssigned toNone=>pepeto
    Wed 08 May 2013 08:56:36 AM UTCpepetoAttached File-=>Added airplane-test.sav.gz, #17926
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup