bugFreeciv - Bugs: bug #20835, minplayers limitation applied when...

 
 
Show feedback again

bug #20835: minplayers limitation applied when continuing from saved game

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 22 May 2013 10:25:21 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.5, 2.4.0, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 30 Jun 2013 05:57:59 AM UTC, SVN revision 22997:

Ignore minplayers setting when continuing already started saved game.

See bug #20835

(Browse SVN revision 22997)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 30 Jun 2013 05:57:54 AM UTC, SVN revision 22996:

Ignore minplayers setting when continuing already started saved game.

See bug #20835

(Browse SVN revision 22996)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 30 Jun 2013 05:57:48 AM UTC, SVN revision 22995:

Ignore minplayers setting when continuing already started saved game.

See bug #20835

(Browse SVN revision 22995)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 30 Jun 2013 05:57:42 AM UTC, SVN revision 22994:

Ignore minplayers setting when continuing already started saved game.

See bug #20835

(Browse SVN revision 22994)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 26 Jun 2013 11:11:35 AM UTC, comment #1:

Fix

Minplayers is needed in the beginning of the game so they are present when map is created and starting locations assigned. There's no similar need for minplayers when loading saved game - even if players are not present when game restarts, they can connect to their existing player afterwards.

Games with timeout set are problematic, though. If someone has been using minplayers setting to make sure everyone is present before timeout counter starts to run after savegame is loaded, that use-case will break.

(file #18175)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 22 May 2013 10:25:21 AM UTC, original submission:

We had minplayers set to 4 so that one could mark himself ready as soon as one has connected - no need to wait for everybody to be connected before then waiting everyone to hit "Ready".
One of the human players has since died, so there's only 3 (< minplayers) alive human players. After server reboot, game was meant to continue from saved game. It refused to start due to minplayers limitation. Further, minplayers setting cannot be changed after game has begun.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18175:  MinplayersSkip.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Jun 2013 05:58:12 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 26 Jun 2013 11:11:35 AM UTCcazfiAttached File-=>Added MinplayersSkip.patch, #18175
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.3.5, 2.4.0, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup