bugFreeciv - Bugs: bug #20844, Effects.ruleset...

 
 
Show feedback again

bug #20844: Effects.ruleset [effect_maint_player] has unknown req: Building" "Service Shop"

Submitted by:  None
Submitted on:  Sat 25 May 2013 03:59:18 PM UTC  
 
Category: rulesetsSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenRelease: FreeCiv 2.4.0 Beta 2 gui-gtk 2.0 client
Operating System: Microsoft WindowsPlanned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 29 May 2013 09:04:45 AM UTC, comment #3:

when i shifted from[building_work_bay]
name = _("Service Bay")
genus = "Improvement"
reqs =
{ "type", "name", "range"
"Tech", "Invention", "Player"
"MinSize", "10", "City"
}
To

[building_work_bay]
name = _("Service Bay")
genus = "SmallWonder"
reqs =
{ "type", "name", "range"
"Tech", "Invention", "Player"
"MinSize", "10", "City"
}

And removed the extra service bays Fixed the Problem now get the upgraded units. thanks for the help.

Anonymous
Wed 29 May 2013 08:34:00 AM UTC, comment #2:

i have noticed on several of my ruleset tweks this type of error. part of why i used improvement is that in ver 2.? i was able to get a similer building to work on player. i was trying to get the service shop made that required me to get the units to where the city was woking tiles to have a unit upgraded.
i would be nice if someone would document more on the effects for valid ranges, and aplied to

ie
upgrade_unit valid for wonders and small wanders only valid range of player or world.

Anonymous
Tue 28 May 2013 05:58:33 PM UTC, comment #1:

This would require changes to unittools.c:do_upgrade_effects(), as the current logic only checks for upgrade counts on a per-player basis, meaning that only World and Player ranges can be used to control the Upgrade_Unit effect (as there is no available information regarding the continent, city, tile, etc.).

That aside, I'm not sure why the Building is an unknown requirement: looks like it might be a missing comma from the error message, but that's a wild guess (as I don't see the corresponding missing comma in the presented ruleset code).

Emmet Hikory <persia>
Project Member
Sat 25 May 2013 03:59:18 PM UTC, original submission:

Upgrade_Unit only works for Leonardo's Workshop

Tried Several Variations

[effect_maint_player]
name = "Upgrade_Unit"
value = 1
reqs =
{ "type", "name", "range"
"Building", "Service Shop", "RANGE"
}
Player and Continent Got same error

Local and City Load and run but do not upgrade units

more info and effects.ruleset add and building ruleset add in attached files i did have this working in freeciv 2.2.? i thing can't access due to drive crash

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18008:  Upgrade_Unit Problems.txt added by None (3kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 25 May 2013 03:59:19 PM UTCNoneAttached File-=>Added Upgrade_Unit Problems.txt, #18008
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup