bugBattle for Wesnoth - Bugs: bug #20861, Modifications

 
 
Show feedback again

bug #20861: Modifications

Submitted by:  trewe <trewe>
Submitted on:  Sun Jun 2 12:27:16 2013  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer
Status: FixedPrivacy: Public
Assigned to: B. Lipka <lipk>Open/Closed: Closed
Release: 1.11.4Operating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue Oct 18 16:59:46 2016, comment #5:

Assuming to be fixed.

Daniel <gfgtdf>
Project Member
Tue Jun 4 20:11:11 2013, comment #4:

No, I broke it while fixing an other bug (commit eb1f002e81723ea66c37f2e0e1438f91f1afa6cc). I'm going to revert that for the time being, since this bug is more problematic (you might have not noticed yet, but no-install eras are also broken :P), and the approach I used there won't work anyways.

B. Lipka <lipk>
Project MemberIn charge of this item.
Tue Jun 4 19:56:26 2013, comment #3:

Note that I assigned it to you since you are probably best suited to fix it, but that you are rather unlikely to be responsible for the problem, so you could just throw it at the feet of whoever committer who is. ;)

Anonymissimus <anonymissimus>
Project Member
Tue Jun 4 18:18:15 2013, comment #2:

I'll see where it is broken, but it's not a trivial fix and I'm rather busy atm, so it'll take a while.

B. Lipka <lipk>
Project MemberIn charge of this item.
Sun Jun 2 19:14:46 2013, comment #1:

PYAM's author here. I can reproduce the problem using trunk 1.11.4-234-g8e74136 and PYAM umc-dev r16518. However, I remember that this error (mandatory wml child missing) did not appear the last time I tested it. This must have been roughly at the time I made the last release of PYAM (02.12.2012), and I am pretty sure that the problem is caused by the engine, as opposed to the addon.

However, do note that the modification needs to be designed in such way that it should not require remote clients to download it. If the author creates a custom unit, custom terrain or such it's his fault that it of course doesn't work. PYAM was guilty of this too at some spot (but no more).

Anonymissimus <anonymissimus>
Project Member
Sun Jun 2 12:27:16 2013, original submission:

When joining a game which uses a modification all players need to have it installed (when they work correctly) otherwise clients not having them are kicked as soon the host starts the game.

Assuming 'Plan Your Advancements' even states that non-hosts should not need it, it does not look indented.

Tested with almost every modification currently available.

Confirmed from feedback from other users.

Attached the error output of the host (launched game with normal userdata) and another client (launched game pointing to an empty userdata), with PYA enabled.

trewe <trewe>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #18044:  error.log added by trewe (3kB - text/x-log - the log files)
file #18045:  non-host_error.log added by trewe (894B - text/x-log - the log files)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by vultraz (Updated the item)
  • -unavailable- added by gfgtdf (Posted a comment)
  • -unavailable- added by lipk (Posted a comment)
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by trewe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Nov 7 08:07:15 2016vultrazOpen/ClosedOpen=>Closed
    Tue Oct 18 16:59:46 2016gfgtdfStatusConfirmed=>Fixed
    Tue Jun 4 18:18:15 2013lipkStatusNone=>Confirmed
    Sun Jun 2 19:16:51 2013anonymissimusAssigned toNone=>lipk
    Sun Jun 2 12:27:16 2013treweAttached File-=>Added error.log, #18044
      Attached File-=>Added non-host_error.log, #18045
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup